[patch] fix for bug

0001-user32-Don-t-ignore-return-value-of-MapWindowPoints.txt (text/plain), 1.09 KB, created by Daniel Santos on 2012-10-16 01:17:49 UTC

From 367768b3300e0342a57a27b56a9a45e08c028ce7 Mon Sep 17 00:00:00 2001
From: Daniel Santos <[e-mail]>
Date: Mon, 15 Oct 2012 15:12:59 -0500
Subject: user32: Don't ignore return value of MapWindowPoints

ScreenToClient should return zero if the operation fails, but is always
returning TRUE.  This patch corrects the problem and solves a crash bug
in Lord of the Rings Online (bug #31979)

Credit for this patch goes to some one else, as yet unidentified, since
it originally came from a closed forum for beta testers of the LoTRO
Riders of Rohan expansion and the forum has subsequently been wiped.
---
 dlls/user32/winpos.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/dlls/user32/winpos.c b/dlls/user32/winpos.c
index 5a2f1f2..3855b19 100644
--- a/dlls/user32/winpos.c
+++ b/dlls/user32/winpos.c
@@ -250,8 +250,7 @@ BOOL WINAPI ClientToScreen( HWND hwnd, LPPOINT lppnt )
  */
 BOOL WINAPI ScreenToClient( HWND hwnd, LPPOINT lppnt )
 {
-    MapWindowPoints( 0, hwnd, lppnt, 1 );
-    return TRUE;
+    return MapWindowPoints( 0, hwnd, lppnt, 1 ) != 0;
 }
 
 
-- 
1.7.3.4