Avoid kernel complaints with >= 3.3 kernels about extra (unused) padding after netlink attributes. --- --- collectd-a/src/netlink.c 2012-03-21 19:20:15.304227640 +0100 +++ collectd-b/src/netlink.c 2012-03-21 19:21:20.454323202 +0100 @@ -223,7 +223,7 @@ static int link_filter (const struct soc msg = NLMSG_DATA (nmh); - msg_len = nmh->nlmsg_len - sizeof (struct ifinfomsg); + msg_len = nmh->nlmsg_len - NLMSG_LENGTH(sizeof (struct ifinfomsg)); if (msg_len < 0) { ERROR ("netlink plugin: link_filter: msg_len = %i < 0;", msg_len); @@ -554,17 +554,13 @@ static int ir_init (void) static int ir_read (void) { - struct ifinfomsg im; struct tcmsg tm; int ifindex; static const int type_id[] = { RTM_GETQDISC, RTM_GETTCLASS, RTM_GETTFILTER }; static const char *type_name[] = { "qdisc", "class", "filter" }; - memset (&im, '\0', sizeof (im)); - im.ifi_type = AF_UNSPEC; - - if (rtnl_dump_request (&rth, RTM_GETLINK, &im, sizeof (im)) < 0) + if (rtnl_wilddump_request (&rth, AF_UNSPEC, RTM_GETLINK) < 0) { ERROR ("netlink plugin: ir_read: rtnl_dump_request failed."); return (-1);