[patch] suggested patch based on upstream bug 648592

0001-Make-Banshee-optimize-database-when-importing-large-.patch (text/plain), 2.21 KB, created by Trevor Bowen on 2011-07-08 15:46:34 UTC

From 03312de37a57f94e6b9b435ffcec37e201393a4d Mon Sep 17 00:00:00 2001
From: Mackenan Grassi <[e-mail]>
Date: Sat, 11 Jun 2011 15:08:45 -0700
Subject: [PATCH] Make Banshee optimize database when importing large quantity of files

Importing 5,000+ files would dramatically slow down the database, causing high CPU usage and making the import process take far longer than it ever should. Upon restarting Banshee, everything would work normally because on startup Banshee would optimize the database. This patch makes Banshee optimize the database throughout the import process to prevent it from slowing down.
---
 .../DatabaseImportManager.cs                       |    1 +
 .../Banshee.Database/BansheeDbConnection.cs        |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/src/Core/Banshee.Services/Banshee.Collection.Database/DatabaseImportManager.cs b/src/Core/Banshee.Services/Banshee.Collection.Database/DatabaseImportManager.cs
index 39f48a0..d9cd806 100644
--- a/src/Core/Banshee.Services/Banshee.Collection.Database/DatabaseImportManager.cs
+++ b/src/Core/Banshee.Services/Banshee.Collection.Database/DatabaseImportManager.cs
@@ -205,6 +205,7 @@ namespace Banshee.Collection.Database
             // Reload every 20% or every 250 tracks, whatever is more (eg at most reload 5 times during an import)
             if (counts[track.PrimarySourceId] >= Math.Max (TotalCount/5, 250)) {
                 counts[track.PrimarySourceId] = 0;
+                ServiceManager.DbConnection.OptimizeDatabase ();
                 track.PrimarySource.NotifyTracksAdded ();
             }
 
diff --git a/src/Core/Banshee.Services/Banshee.Database/BansheeDbConnection.cs b/src/Core/Banshee.Services/Banshee.Database/BansheeDbConnection.cs
index e9bbbf5..363b935 100644
--- a/src/Core/Banshee.Services/Banshee.Database/BansheeDbConnection.cs
+++ b/src/Core/Banshee.Services/Banshee.Database/BansheeDbConnection.cs
@@ -117,7 +117,7 @@ namespace Banshee.Database
             }
         }
 
-        private void OptimizeDatabase ()
+        public void OptimizeDatabase ()
         {
             bool needs_analyze = false;
             long analyze_threshold = configuration.Get<long> ("Database", "AnalyzeThreshold", 100);
-- 
1.7.3.4