Go to:
Gentoo Home
Documentation
Forums
Lists
Bugs
Planet
Store
Wiki
Get Gentoo!
Gentoo's Bugzilla – Attachment 263763 Details for
Bug 356389
dodoc ignores exit status of underlying install
Home
|
New
–
[Ex]
|
Browse
|
Search
|
Privacy Policy
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
updated patch
0001-dodoc-Honour-exit-status-of-install-bug-356389.patch (text/plain), 1.52 KB, created by
Ulrich Müller
on 2011-02-25 08:55:15 UTC
(
hide
)
Description:
updated patch
Filename:
MIME Type:
Creator:
Ulrich Müller
Created:
2011-02-25 08:55:15 UTC
Size:
1.52 KB
patch
obsolete
>From 3affb118abd56eeaf9116c0e07b9962650bf73ee Mon Sep 17 00:00:00 2001 >From: Ulrich Mueller <ulm@gentoo.org> >Date: Fri, 25 Feb 2011 08:43:17 +0100 >Subject: [PATCH] dodoc: Honour exit status of install, bug 356389. > >--- > bin/ebuild-helpers/4/dodoc | 4 +++- > bin/ebuild-helpers/dodoc | 7 +++++-- > 2 files changed, 8 insertions(+), 3 deletions(-) > >diff --git a/bin/ebuild-helpers/4/dodoc b/bin/ebuild-helpers/4/dodoc >index d32343c..66a1f08 100755 >--- a/bin/ebuild-helpers/4/dodoc >+++ b/bin/ebuild-helpers/4/dodoc >@@ -27,6 +27,8 @@ for x in "$@" ; do > > if [ -d "${x}" ] ; then > if [[ ${DOINSRECUR} == "n" ]] ; then >+ echo "!!! ${0##*/}: $x is a directory" 1>&2 >+ ((ret|=1)) > continue > fi > >@@ -36,7 +38,7 @@ for x in "$@" ; do > ${0} -r {} \; > > elif [ -s "${x}" ] ; then >- install -m0644 "${x}" "${dir}" >+ install -m0644 "${x}" "${dir}" || ((ret|=1)) > elif [ ! -e "${x}" ] ; then > echo "!!! ${0##*/}: $x does not exist" 1>&2 > ((ret|=1)) >diff --git a/bin/ebuild-helpers/dodoc b/bin/ebuild-helpers/dodoc >index 29b6901..c22e750 100755 >--- a/bin/ebuild-helpers/dodoc >+++ b/bin/ebuild-helpers/dodoc >@@ -16,8 +16,11 @@ fi > > ret=0 > for x in "$@" ; do >- if [ -s "${x}" ] ; then >- install -m0644 "${x}" "${dir}" >+ if [ -d "${x}" ] ; then >+ eqawarn "QA Notice: dodoc argument '${x}' is a directory" >+ continue >+ elif [ -s "${x}" ] ; then >+ install -m0644 "${x}" "${dir}" || { ((ret|=1)); continue; } > ecompress --queue "${dir}/${x##*/}" > elif [ ! -e "${x}" ] ; then > echo "!!! ${0##*/}: $x does not exist" 1>&2 >-- >1.7.4.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 356389
:
263759
|
263763
|
263765