[patch] The described patch

portage-315735-repoman-metadata-useflag-errors.diff (text/plain), 1.62 KB, created by Michał Górny on 2010-04-17 12:51:11 UTC

commit 90883c6e9fa2b8cb64aa07832724418cb163f50d
Author: Michał Górny <[e-mail]>
Date:   Sat Apr 17 14:26:49 2010 +0200

    Make metadata.xml <flag/> errors non-fatal to repoman. Previously
    they caused repoman to die without reporting the full path to broken
    metadata.xml. Now they are reported as 'metadata.bad'.

diff --git a/bin/repoman b/bin/repoman
index 23fcd4d..aa3a952 100755
--- a/bin/repoman
+++ b/bin/repoman
@@ -1314,7 +1314,13 @@ for x in scanlist:
 			del e
 		else:
 			# load USE flags from metadata.xml
-			utilities.parse_metadata_use(_metadata_xml, muselist)
+			try:
+				utilities.parse_metadata_use(_metadata_xml, muselist)
+			except portage.exception.ParseError as e:
+				metadata_bad = True
+				stats["metadata.bad"] += 1
+				fails["metadata.bad"].append("%s/metadata.xml: %s" % (x, e))
+				muselist = []
 
 			# Run other metadata.xml checkers
 			try:
diff --git a/pym/repoman/utilities.py b/pym/repoman/utilities.py
index 52ebba7..3050804 100644
--- a/pym/repoman/utilities.py
+++ b/pym/repoman/utilities.py
@@ -119,14 +119,12 @@ def parse_metadata_use(xml_tree, uselist=None):
 
 	flags = usetag[0].findall("flag")
 	if not flags:
-		raise exception.ParseError("metadata.xml: " + \
-			"Malformed input: missing 'flag' tag(s)")
+		raise exception.ParseError("missing 'flag' tag(s)")
 
 	for flag in flags:
 		pkg_flag = flag.get("name")
 		if pkg_flag is None:
-			raise exception.ParseError("metadata.xml: " + \
-				"Malformed input: missing 'name' attribute for 'flag' tag")
+			raise exception.ParseError("missing 'name' attribute for 'flag' tag")
 		uselist.append(pkg_flag)
 	return uselist