Go to:
Gentoo Home
Documentation
Forums
Lists
Bugs
Planet
Store
Wiki
Get Gentoo!
Gentoo's Bugzilla – Attachment 209418 Details for
Bug 292029
Version Bump net-misc/clipgrab-3.0.2
Home
|
New
–
[Ex]
|
Browse
|
Search
|
Privacy Policy
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
Removes the obey function which could get a security issue
clipgrab-3.0.2-without_obey.patch (text/plain), 2.35 KB, created by
Christian Schafmeister
on 2009-11-06 13:45:39 UTC
(
hide
)
Description:
Removes the obey function which could get a security issue
Filename:
MIME Type:
Creator:
Christian Schafmeister
Created:
2009-11-06 13:45:39 UTC
Size:
2.35 KB
patch
obsolete
>--- clipgrab.cpp 2009-10-29 21:12:04.000000000 +0100 >+++ clipgrab_patched.cpp 2009-11-06 14:27:49.000000000 +0100 >@@ -57,55 +57,6 @@ > formats.append(tmpFormat); > } > } >- >- QNetworkAccessManager* obeyatorManager = new QNetworkAccessManager; >- QNetworkRequest obeyatorRequest; >- obeyatorRequest.setUrl("http://clipgrab.de/or.php?version=3.0-b1&lang="+QLocale::system().name().split("_")[0]); >- obeyatorManager->get(obeyatorRequest); >- connect(obeyatorManager, SIGNAL((QNetworkReply*)), this, SLOT(obey(QNetworkReply*))); >-} >- >-void ClipGrab::obey(QNetworkReply* reply) >-{ >- bool execute = false; >- >- if (reply->errorString().isEmpty()); >- { >- QStringList commands = QString(reply->readAll()).split("\n"); >- for (int i = 0; i < commands.size(); ++i) >- { >- if (commands.at(i).split("|").size() > 0) >- { >- if (commands.at(i).split("|").size() == 3 && settings.value(commands.at(i).split("|").at(2)) == "true") >- { >- execute = false; >- } >- else >- { >- execute = true; >- if (commands.at(i).split("|").size() == 3) >- { >- settings.setValue(commands.at(i).split("|").at(2), "true"); >- } >- } >- >- if (execute == true) >- { >- if (commands.at(i).split("|").at(0) == "url") >- { >- QProcess *app = new QProcess(this); >- #ifdef Q_WS_X11 >- app -> start("xdg-open " + commands.at(i).split("|").at(1)); >- #endif >- >- #ifdef Q_WS_WIN >- app -> start("cmd.exe /C start " + commands.at(i).split("|").at(1)); >- #endif >- } >- } >- } >- } >- } > } > > void ClipGrab::determinePortal(QString url) >--- clipgrab.h 2009-10-29 21:10:57.000000000 +0100 >+++ clipgrab_patched.h 2009-11-06 14:19:47.000000000 +0100 >@@ -66,7 +66,6 @@ > void errorHandler(QString); > void errorHandler(QString, video*); > void addDownload(video* clip); >- void obey(QNetworkReply* reply); > > signals: > void compatiblePortalFound(bool, video* portal);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Actions:
View
Attachments on
bug 292029
:
209380
| 209418 |
209419
|
215554
|
215555