Go to:
Gentoo Home
Documentation
Forums
Lists
Bugs
Planet
Store
Wiki
Get Gentoo!
Gentoo's Bugzilla – Attachment 189740 Details for
Bug 261431
konsole-4.4.1 and earlier doesn't honour "Word characters for double-click selection" option.
Home
|
New
–
[Ex]
|
Browse
|
Search
|
Privacy Policy
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
patch for konsole 4.2.2
wordchar-selection.patch (text/plain), 1.80 KB, created by
DarkNRG
on 2009-04-28 21:22:31 UTC
(
hide
)
Description:
patch for konsole 4.2.2
Filename:
MIME Type:
Creator:
DarkNRG
Created:
2009-04-28 21:22:31 UTC
Size:
1.80 KB
patch
obsolete
>--- konsole/src/TerminalDisplay.cpp 2009-04-28 23:12:42.263506864 +0200 >+++ konsole/src/TerminalDisplay.cpp 2009-04-28 23:12:42.263506864 +0200 >@@ -2172,12 +2172,11 @@ > _wordSelectionMode = true; > > // find word boundaries... >- QChar selClass = charClass(_image[i].character); > { > // find the start of the word > int x = bgnSel.x(); > while ( ((x>0) || (bgnSel.y()>0 && (_lineProperties[bgnSel.y()-1] & LINE_WRAPPED) )) >- && charClass(_image[i-1].character) == selClass ) >+ && !isCharBoundary(_image[i-1].character) ) > { > i--; > if (x>0) >@@ -2196,7 +2195,7 @@ > i = loc( endSel.x(), endSel.y() ); > x = endSel.x(); > while( ((x<_usedColumns-1) || (endSel.y()<_usedLines-1 && (_lineProperties[endSel.y()] & LINE_WRAPPED) )) >- && charClass(_image[i+1].character) == selClass ) >+ && !isCharBoundary(_image[i+1].character) ) > { > i++; > if (x<_usedColumns-1) >@@ -2342,6 +2341,16 @@ > } > > >+// Returns true upon a word boundary >+// TODO determine if the below charClass() is actually required >+bool TerminalDisplay::isCharBoundary(QChar qch) const >+{ >+ if ( _wordCharacters.contains(qch, Qt::CaseInsensitive) ) return true; >+ if ( qch.isSpace() ) return true; >+ return false; >+} >+ >+ > bool TerminalDisplay::focusNextPrevChild( bool next ) > { > if (next) >--- konsole/src/TerminalDisplay.h 2009-04-28 23:12:42.263506864 +0200 >+++ konsole/src/TerminalDisplay.h 2009-04-28 23:12:42.263506864 +0200 >@@ -566,6 +563,9 @@ > // - Other characters (returns the input character) > QChar charClass(QChar ch) const; > >+ // Returns true upon a word boundary >+ bool isCharBoundary(QChar ch) const; >+ > void clearImage(); > > void mouseTripleClickEvent(QMouseEvent* ev);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 261431
:
185322
|
185324
| 189740 |
189741