[patch] Updated parallel make patch

gnome-user-docs-2.24.2-parallel-make.patch (text/plain), 2.43 KB, created by Martin von Gagern on 2009-03-06 11:25:43 UTC

Thr first bunch of changes replaces install-data-local with
install-data-hooks. I, Martin von Gagern, at the time I'm writing this
header, don't fully comprehend the reason behind this.  The original patch
by Gilles Dartiguelongue contained no header at all. See the references
below for updates on this.

The second issue seems to be caused by the following scenario:
 * install-data-local (now install-data-hooks) depends on both
   install-doc-docs and install-doc-pdf.
 * both these targets create their output subdirectories using mkinstalldirs.
 * install-sh seems to have provisions for concurrent execution, but only
   when installing files, not when invoked to create directories.

The patch addresses the issue by having install-doc-pdf not create any
directories itself, but depend on install-doc-docs to do that.

As an alternative, it might be possible to drop the explicit directory
creation altogether, and rely on the implicit and concurrency-aware
directory creation of install-sh. The patch below is closer to original
behaviour, and thus may be more portable, even in cases where install-sh
would not be concurrency-aware.

2009-01-11 Gilles Dartiguelongue
2009-03-06 Martin von Gagern

References:
https://bugs.gentoo.org/252163
https://bugs.gentoo.org/260827

--- a/gnome2-accessibility-guide/Makefile.am	2009-01-11 22:50:31.000000000 +0100
+++ b/gnome2-accessibility-guide/Makefile.am	2009-01-11 22:51:27.000000000 +0100
@@ -14,7 +14,7 @@
 
 DOC_LINGUAS = de el en_GB es fi fr hu it oc pt sv
 
-install-data-local: install-doc-pdf
+install-data-hook: install-doc-pdf
 install-doc-pdf:
 	for lc in C $(DOC_LINGUAS); do \
 	  pdf="$$lc/$(DOC_MODULE).pdf"; \
--- a/gnome2-user-guide/Makefile.am	2009-01-11 22:50:27.000000000 +0100
+++ b/gnome2-user-guide/Makefile.am	2009-01-11 22:51:49.000000000 +0100
@@ -17,7 +17,7 @@
 
 DOC_LINGUAS = ar bg de el es fi fr hu it ja ko oc pa pt pt_BR ru sv th zh_CN
 
-install-data-local: install-doc-pdf
+install-data-hook: install-doc-pdf
 install-doc-pdf:
 	for lc in C $(DOC_LINGUAS); do \
 	  pdf="$$lc/$(DOC_MODULE).pdf"; \
--- a/gnome2-system-admin-guide/Makefile.am	2009-01-11 22:45:28.000000000 +0100
+++ b/gnome2-system-admin-guide/Makefile.am	2009-01-11 22:50:16.000000000 +0100
@@ -20,7 +20,7 @@
 
 DOC_LINGUAS = ca de el es fi fr it ja ko oc pa pt sv zh_CN
 
-install-data-local: install-doc-pdf
+install-data-hook: install-doc-pdf
 install-doc-pdf:
 	for lc in C $(DOC_LINGUAS); do \
 	  pdf="$$lc/$(DOC_MODULE).pdf"; \