Go to:
Gentoo Home
Documentation
Forums
Lists
Bugs
Planet
Store
Wiki
Get Gentoo!
Gentoo's Bugzilla – Attachment 174604 Details for
Bug 250212
[patch] repoman marks "emake -j1" as a minor syntax error, when it's syntacically correct and recommended
Home
|
New
–
[Ex]
|
Browse
|
Search
|
Privacy Policy
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch for trunk that adds "upstream.workaround" and associated help text
repoman-emake-warning.patch (text/plain), 2.29 KB, created by
Mike Auty (RETIRED)
on 2008-12-07 22:10:17 UTC
(
hide
)
Description:
Patch for trunk that adds "upstream.workaround" and associated help text
Filename:
MIME Type:
Creator:
Mike Auty (RETIRED)
Created:
2008-12-07 22:10:17 UTC
Size:
2.29 KB
patch
obsolete
>diff --git a/bin/repoman b/bin/repoman >index 9dc6ed6..fc24925 100755 >--- a/bin/repoman >+++ b/bin/repoman >@@ -314,7 +314,8 @@ qahelp={ > "virtual.versioned":"PROVIDE contains virtuals with versions", > "virtual.exists":"PROVIDE contains existing package names", > "virtual.unavailable":"PROVIDE contains a virtual which contains no profile default", >- "usage.obsolete":"The ebuild makes use of an obsolete construct" >+ "usage.obsolete":"The ebuild makes use of an obsolete construct", >+ "upstream.workaround":"The ebuild works around an upstream bug, an upstream bug should be filed and tracked in bugs.gentoo.org" > } > > qacats = qahelp.keys() >@@ -350,6 +351,7 @@ qawarnings = set(( > "virtual.exists", > "virtual.unavailable", > "usage.obsolete", >+"upstream.workaround", > "LIVEVCS.stable" > )) > >diff --git a/man/repoman.1 b/man/repoman.1 >index c6d83d5..dde0d15 100644 >--- a/man/repoman.1 >+++ b/man/repoman.1 >@@ -263,6 +263,10 @@ Bad metadata.xml files > .B metadata.missing > Missing metadata.xml files > .TP >+.B upstream.workaround >+The ebuild works around an upstream bug, an upstream bug should be filed and >+tracked in bugs.gentoo.org >+.TP > .B usage.obsolete > The ebuild makes use of an obsolete construct > .TP >diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py >index c9415b7..c90b54f 100644 >--- a/pym/repoman/checks.py >+++ b/pym/repoman/checks.py >@@ -291,7 +291,7 @@ class IUseUndefined(LineCheck): > > class EMakeParallelDisabled(LineCheck): > """Check for emake -j1 calls which disable parallelization.""" >- repoman_check_name = 'ebuild.minorsyn' >+ repoman_check_name = 'upstream.workaround' > re = re.compile(r'^\s*emake\s+-j\s*1\s') > error = errors.EMAKE_PARALLEL_DISABLED > >diff --git a/pym/repoman/errors.py b/pym/repoman/errors.py >index 7c54cc1..7f45bea 100644 >--- a/pym/repoman/errors.py >+++ b/pym/repoman/errors.py >@@ -13,5 +13,5 @@ MISSING_QUOTES_ERROR = 'Unquoted Variable on line: %d' > NESTED_DIE_ERROR = 'Ebuild calls die in a subshell on line: %d' > PATCHES_ERROR = 'PATCHES is not a bash array on line: %d' > REDUNDANT_CD_S_ERROR = 'Ebuild has redundant cd ${S} statement on line: %d' >-EMAKE_PARALLEL_DISABLED = 'Ebuild calls emake -j1 on line: %d' >+EMAKE_PARALLEL_DISABLED = 'Upstream parallel compilation bug (ebuild calls emake -j1 on line: %d)' > DEPRECATED_BINDNOW_FLAGS = 'Deprecated bindnow-flags call on line: %d'
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 250212
: 174604