[patch] proposed no-strndup patch

p.patch (text/plain), 1.20 KB, created by Fabian Groffen on 2008-12-03 20:48:58 UTC

? .gdb_history
? libz.dylib
? man/dumpelf.1
? man/pspax.1
? man/scanelf.1
? man/scanmacho.1
Index: scanelf.c
===================================================================
RCS file: /var/cvsroot/gentoo-projects/pax-utils/scanelf.c,v
retrieving revision 1.198
diff -u -r1.198 scanelf.c
--- scanelf.c	17 Nov 2008 18:09:55 -0000	1.198
+++ scanelf.c	3 Dec 2008 20:48:35 -0000
@@ -1039,7 +1039,7 @@
 					while (next_sym) { \
 						this_sym = next_sym; \
 						if ((next_sym = strchr(this_sym, ','))) \
-							next_sym += 1; /* Skip the comma */ \
+							*next_sym++ = '\0'; /* Skip the comma */ \
 						/* do we want a defined symbol ? */ \
 						if (*this_sym == '+') { \
 							if (sym->st_shndx == SHN_UNDEF) \
@@ -1051,8 +1051,6 @@
 								continue; \
 							++this_sym; \
 						} \
-						if (next_sym) /* Copy it so that we don't have to worry about the final , */ \
-							this_sym = strndup(this_sym, next_sym-this_sym); \
 						/* ok, lets compare the name now */ \
 						if (scanelf_match_symname(this_sym, symname)) { \
 							if (be_semi_verbose) { \
@@ -1065,7 +1063,6 @@
 							(*found_sym)++; \
 							goto break_out; \
 						} \
-						if (next_sym) free(this_sym); \
 					} \
 				} \
 			} \