robbat2's demonstration of the cvs server bug triggered by a ./ prefix on file paths

cvs_server_bug.txt (text/plain), 5.82 KB, created by Zac Medico on 2008-11-14 08:12:50 UTC

==== /tmp/commit.bad
# cvs -n -t commit -m 'Testing.' ./files/my.cnf-4.1 ./ChangeLog
  -> main: Session ID is 46e1491d05bc4567
  -> main loop with CVSROOT=/var/cvsroot
  -> open_connection_to_server (:ext:[e-mail]:/var/cvsroot)
 -> Starting server: ssh -l robbat2 cvs.gentoo.org cvs server 
  -> Sending file `my.cnf-4.1' to server
  -> Sending file `ChangeLog' to server
S -> serve_directory (./files)
S -> dirswitch (./files, /var/cvsroot/gentoo-x86/dev-db/mysql-community/files)
S -> serve_directory (.)
S -> dirswitch (., /var/cvsroot/gentoo-x86/dev-db/mysql-community)
S -> serve_directory (.)
S -> dirswitch (., /var/cvsroot/)
S -> do_cvs_command (commit)
S -> server_notify()
S -> lock_tree_promotably (2, argv, 0, 1, 0)
S -> server_pathname_check (./files/my.cnf-4.1)
S -> server_pathname_check (ChangeLog)
S -> server_pathname_check (./files/my.cnf-4.1)
S -> server_pathname_check (ChangeLog)
S -> RCS_cmp_file( /var/cvsroot/gentoo-x86/dev-db/mysql-community/files/my.cnf-4.1,v, 1.2, (null), , my.cnf-4.1 )
S -> RCS_checkout (/var/cvsroot/gentoo-x86/dev-db/mysql-community/files/my.cnf-4.1,v, 1.2, , , (function))
S -> Parse_Info (/var/cvsroot/CVSROOT/commitinfo, gentoo-x86/dev-db/mysql-community/files, ALL)
S -> system ('/var/cvsroot/CVSROOT/cvslogdate' '/var/cvsroot/gentoo-x86/dev-db/mysql-community/files' 'my.cnf-4.1')
cvs commit: Up-to-date check failed for `ChangeLog'
cvs [commit aborted]: correct above errors first!
S -> Lock_Cleanup()
S -> Simple_Lock_Cleanup()
S -> server_cleanup()
  -> close_connection_to_server ()
S -> Lock_Cleanup()
S -> Simple_Lock_Cleanup()
S -> server_cleanup()
==== /tmp/commit.good
# cvs -n -t commit -m 'Testing.' files/my.cnf-4.1 ChangeLog
  -> main: Session ID is 46e5491d05cb4567
  -> main loop with CVSROOT=/var/cvsroot
  -> open_connection_to_server (:ext:[e-mail]:/var/cvsroot)
 -> Starting server: ssh -l robbat2 cvs.gentoo.org cvs server 
  -> Sending file `my.cnf-4.1' to server
  -> Sending file `ChangeLog' to server
S -> serve_directory (files)
S -> dirswitch (files, /var/cvsroot/gentoo-x86/dev-db/mysql-community/files)
S -> serve_directory (.)
S -> dirswitch (., /var/cvsroot/gentoo-x86/dev-db/mysql-community)
S -> do_cvs_command (commit)
S -> server_notify()
S -> lock_tree_promotably (2, argv, 0, 1, 0)
S -> server_pathname_check (files/my.cnf-4.1)
S -> server_pathname_check (ChangeLog)
S -> server_pathname_check (files/my.cnf-4.1)
S -> server_pathname_check (ChangeLog)
S -> RCS_cmp_file( /var/cvsroot/gentoo-x86/dev-db/mysql-community/files/my.cnf-4.1,v, 1.2, (null), , my.cnf-4.1 )
S -> RCS_checkout (/var/cvsroot/gentoo-x86/dev-db/mysql-community/files/my.cnf-4.1,v, 1.2, , , (function))
S -> Parse_Info (/var/cvsroot/CVSROOT/commitinfo, gentoo-x86/dev-db/mysql-community/files, ALL)
S -> system ('/var/cvsroot/CVSROOT/cvslogdate' '/var/cvsroot/gentoo-x86/dev-db/mysql-community/files' 'my.cnf-4.1')
S -> RCS_cmp_file( /var/cvsroot/gentoo-x86/dev-db/mysql-community/ChangeLog,v, 1.20, (null), , ChangeLog )
S -> RCS_checkout (/var/cvsroot/gentoo-x86/dev-db/mysql-community/ChangeLog,v, 1.20, , , (function))
S -> Parse_Info (/var/cvsroot/CVSROOT/commitinfo, gentoo-x86/dev-db/mysql-community, ALL)
S -> system ('/var/cvsroot/CVSROOT/cvslogdate' '/var/cvsroot/gentoo-x86/dev-db/mysql-community' 'ChangeLog')
S -> Lock_Cleanup()
S -> Simple_Lock_Cleanup()
  -> close_connection_to_server ()
S -> Lock_Cleanup()
S -> Simple_Lock_Cleanup()
S -> server_cleanup()

==== diff
--- /tmp/commit.bad	2008-11-13 21:00:22.000000000 -0800
+++ /tmp/commit.good	2008-11-13 21:00:31.000000000 -0800
@@ -1,33 +1,33 @@
-# cvs -n -t commit -m 'Testing.' ./files/my.cnf-4.1 ./ChangeLog
-  -> main: Session ID is 46e1491d05bc4567
+# cvs -n -t commit -m 'Testing.' files/my.cnf-4.1 ChangeLog
+  -> main: Session ID is 46e5491d05cb4567
   -> main loop with CVSROOT=/var/cvsroot
   -> open_connection_to_server (:ext:[e-mail]:/var/cvsroot)
  -> Starting server: ssh -l robbat2 cvs.gentoo.org cvs server 
   -> Sending file `my.cnf-4.1' to server
   -> Sending file `ChangeLog' to server
-S -> serve_directory (./files)
-S -> dirswitch (./files, /var/cvsroot/gentoo-x86/dev-db/mysql-community/files)
+S -> serve_directory (files)
+S -> dirswitch (files, /var/cvsroot/gentoo-x86/dev-db/mysql-community/files)
 S -> serve_directory (.)
 S -> dirswitch (., /var/cvsroot/gentoo-x86/dev-db/mysql-community)
-S -> serve_directory (.)
-S -> dirswitch (., /var/cvsroot/)
 S -> do_cvs_command (commit)
 S -> server_notify()
 S -> lock_tree_promotably (2, argv, 0, 1, 0)
-S -> server_pathname_check (./files/my.cnf-4.1)
+S -> server_pathname_check (files/my.cnf-4.1)
 S -> server_pathname_check (ChangeLog)
-S -> server_pathname_check (./files/my.cnf-4.1)
+S -> server_pathname_check (files/my.cnf-4.1)
 S -> server_pathname_check (ChangeLog)
 S -> RCS_cmp_file( /var/cvsroot/gentoo-x86/dev-db/mysql-community/files/my.cnf-4.1,v, 1.2, (null), , my.cnf-4.1 )
 S -> RCS_checkout (/var/cvsroot/gentoo-x86/dev-db/mysql-community/files/my.cnf-4.1,v, 1.2, , , (function))
 S -> Parse_Info (/var/cvsroot/CVSROOT/commitinfo, gentoo-x86/dev-db/mysql-community/files, ALL)
 S -> system ('/var/cvsroot/CVSROOT/cvslogdate' '/var/cvsroot/gentoo-x86/dev-db/mysql-community/files' 'my.cnf-4.1')
-cvs commit: Up-to-date check failed for `ChangeLog'
-cvs [commit aborted]: correct above errors first!
+S -> RCS_cmp_file( /var/cvsroot/gentoo-x86/dev-db/mysql-community/ChangeLog,v, 1.20, (null), , ChangeLog )
+S -> RCS_checkout (/var/cvsroot/gentoo-x86/dev-db/mysql-community/ChangeLog,v, 1.20, , , (function))
+S -> Parse_Info (/var/cvsroot/CVSROOT/commitinfo, gentoo-x86/dev-db/mysql-community, ALL)
+S -> system ('/var/cvsroot/CVSROOT/cvslogdate' '/var/cvsroot/gentoo-x86/dev-db/mysql-community' 'ChangeLog')
 S -> Lock_Cleanup()
 S -> Simple_Lock_Cleanup()
-S -> server_cleanup()
   -> close_connection_to_server ()
 S -> Lock_Cleanup()
 S -> Simple_Lock_Cleanup()
 S -> server_cleanup()
+