Attachment #100444 for bug #126003




    }
  if (ci >= 0)
    {
      g_warning ("%s(): can't add known window %ld to %ld",
		 G_GNUC_PRETTY_FUNCTION, xchild,
		 GSTC_PARENT_XWINDOW (sparent));
      return;
    }

  /* sanity checks */
  if (ci < 0)
    {
      g_warning ("%s(): can't remove unknown window %ld",
		 G_GNUC_PRETTY_FUNCTION, xchild);
      return;
    }


  /* sanity checks */
  if (ci < 0)
    {
      g_warning ("%s(): can't restack unknown window %ld",
		 G_GNUC_PRETTY_FUNCTION, xchild);
      return;
    }
  if (xbelow && bi < 0)
    {
      g_warning ("%s(): can't restack window %ld on top of unknown window %ld",
		 G_GNUC_PRETTY_FUNCTION, xchild,
		 xbelow);
      return;
    }

    {
    case CreateNotify:
      if (xevent->xcreatewindow.parent != xparent)
	g_warning ("%s(): now what is THIS? "
		   "i receive a SubstructureNotify XCreateWindowEvent "
		   "for a *foreign* child (%ld)??? X is on drugs!",
		   G_GNUC_PRETTY_FUNCTION, xevent->xcreatewindow.window);
      else
	gstc_parent_add_child (sparent, xevent->xcreatewindow.window);
      break;




      /* setup the root window event monitor */
      window = gdk_window_ref_from_xid (GDK_ROOT_WINDOW ());
      if (!window)
	g_error ("%s(): root window id %ld invalid? bad bad...",
		 G_GNUC_PRETTY_FUNCTION, GDK_ROOT_WINDOW ());
      gdk_window_add_filter (window,
			     root_event_monitor,
			     window);

    }
  if (!abort && bytes_after_return)
    {
      g_warning ("%s(): Eeek, property has more than %u bytes, stored on harddisk?",
		 G_GNUC_PRETTY_FUNCTION, prop_buffer_lengh);
      abort++;
    }
  if (!abort && expected_format && expected_format != format_returned)
    {
      g_warning ("%s(): Expected format (%u) unmatched (%d), programmer was drunk?",
		 G_GNUC_PRETTY_FUNCTION, expected_format, format_returned);
      abort++;
    }
  if (!abort && prop_data && nitems_return && format_returned)

      xframe = None;
      /* aparently this can happen if a window is destructed shortly after
       * creation, just be silent.
       * g_warning ("%s(): task window id %ld invalid?",
       *            G_GNUC_PRETTY_FUNCTION, task->xwin);
       */
    }


  g_return_if_fail (id > 0);

  if (!g_hook_destroy (&gwmh_desk_hook_list, id))
    g_warning ("%s(): unable to remove notifier (%d)",
	       G_GNUC_PRETTY_FUNCTION, id);
}

void

  g_return_if_fail (id > 0);

  if (!g_hook_destroy (&gwmh_task_hook_list, id))
    g_warning ("%s(): unable to remove notifier (%d)",
	       G_GNUC_PRETTY_FUNCTION, id);
}

static gboolean

  if (hook)
    g_hook_destroy_link (&gwmh_desk_hook_list, hook);
  else
    g_warning ("%s(): unable to remove notifier <%p> (%p)",
	       G_GNUC_PRETTY_FUNCTION, func, func_data);
}

void

  if (hook)
    g_hook_destroy_link (&gwmh_task_hook_list, hook);
  else
    g_warning ("%s(): unable to remove notifier <%p> (%p)",
	       G_GNUC_PRETTY_FUNCTION, func, func_data);
}

static gboolean




      requested_type != AnyPropertyType &&
      requested_type != type_returned)
    {
      g_warning ("%s(): Property has wrong type, probably on crack",
		 G_GNUC_PRETTY_FUNCTION);
      abort++;
    }
  if (!abort && bytes_after_return)
    {
      g_warning ("%s(): Eeek, property has more than %u bytes, stored on harddisk?",
		 G_GNUC_PRETTY_FUNCTION, prop_buffer_lengh);
      abort++;
    }
  if (!abort && expected_format && expected_format != format_returned)
    {
      g_warning ("%s(): Expected format (%u) unmatched (%d), programmer was drunk?",
		 G_GNUC_PRETTY_FUNCTION, expected_format, format_returned);
      abort++;
    }
  if (!abort && prop_data && nitems_return && format_returned)

Return to bug 126003

Lines 172-179 gstc_parent_add_child (GstcParent *spare Link Here

(-)gnome-core-1.4.2/panel/gstc.c.orig (-10 / +10 lines)
172	}	172	}
173	if (ci >= 0)	173	if (ci >= 0)
174	{	174	{
175	g_warning (G_GNUC_PRETTY_FUNCTION "(): can't add known window %ld to %ld",	175	g_warning ("%s(): can't add known window %ld to %ld",
176	xchild,	176	G_GNUC_PRETTY_FUNCTION, xchild,
177	GSTC_PARENT_XWINDOW (sparent));	177	GSTC_PARENT_XWINDOW (sparent));
178	return;	178	return;
179	}	179	}
Lines 207-214 gstc_parent_remove_child (GstcParent *sp Link Here
207	/* sanity checks */	207	/* sanity checks */
208	if (ci < 0)	208	if (ci < 0)
209	{	209	{
210	g_warning (G_GNUC_PRETTY_FUNCTION "(): can't remove unknown window %ld",	210	g_warning ("%s(): can't remove unknown window %ld",
211	xchild);	211	G_GNUC_PRETTY_FUNCTION, xchild);
212	return;	212	return;
213	}	213	}
214		214
Lines 249-262 gstc_parent_restack_child (GstcParent *s Link Here
249	/* sanity checks */	249	/* sanity checks */
250	if (ci < 0)	250	if (ci < 0)
251	{	251	{
252	g_warning (G_GNUC_PRETTY_FUNCTION "(): can't restack unknown window %ld",	252	g_warning ("%s(): can't restack unknown window %ld",
253	xchild);	253	G_GNUC_PRETTY_FUNCTION, xchild);
254	return;	254	return;
255	}	255	}
256	if (xbelow && bi < 0)	256	if (xbelow && bi < 0)
257	{	257	{
258	g_warning (G_GNUC_PRETTY_FUNCTION "(): can't restack window %ld on top of unknown window %ld",	258	g_warning ("%s(): can't restack window %ld on top of unknown window %ld",
259	xchild,	259	G_GNUC_PRETTY_FUNCTION, xchild,
260	xbelow);	260	xbelow);
261	return;	261	return;
262	}	262	}
Lines 297-306 gstc_parent_event_monitor (GdkXEvent *gd Link Here
297	{	297	{
298	case CreateNotify:	298	case CreateNotify:
299	if (xevent->xcreatewindow.parent != xparent)	299	if (xevent->xcreatewindow.parent != xparent)
300	g_warning (G_GNUC_PRETTY_FUNCTION "(): now what is THIS? "	300	g_warning ("%s(): now what is THIS? "
301	"i receive a SubstructureNotify XCreateWindowEvent "	301	"i receive a SubstructureNotify XCreateWindowEvent "
302	"for a foreign child (%ld)??? X is on drugs!",	302	"for a foreign child (%ld)??? X is on drugs!",
303	xevent->xcreatewindow.window);	303	G_GNUC_PRETTY_FUNCTION, xevent->xcreatewindow.window);
304	else	304	else
305	gstc_parent_add_child (sparent, xevent->xcreatewindow.window);	305	gstc_parent_add_child (sparent, xevent->xcreatewindow.window);
306	break;	306	break;

Lines 230-237 gwmh_init (void) Link Here

(-)gnome-core-1.4.2/panel/gwmh.c.orig (-15 / +16 lines)
230	/* setup the root window event monitor */	230	/* setup the root window event monitor */
231	window = gdk_window_ref_from_xid (GDK_ROOT_WINDOW ());	231	window = gdk_window_ref_from_xid (GDK_ROOT_WINDOW ());
232	if (!window)	232	if (!window)
233	g_error (G_GNUC_PRETTY_FUNCTION "(): root window id %ld invalid? bad bad...",	233	g_error ("%s(): root window id %ld invalid? bad bad...",
234	GDK_ROOT_WINDOW ());	234	G_GNUC_PRETTY_FUNCTION, GDK_ROOT_WINDOW ());
235	gdk_window_add_filter (window,	235	gdk_window_add_filter (window,
236	root_event_monitor,	236	root_event_monitor,
237	window);	237	window);
Lines 390-403 get_typed_property_data (Display *xdispl Link Here
390	}	390	}
391	if (!abort && bytes_after_return)	391	if (!abort && bytes_after_return)
392	{	392	{
393	g_warning (G_GNUC_PRETTY_FUNCTION "(): Eeek, property has more than %u bytes, stored on harddisk?",	393	g_warning ("%s(): Eeek, property has more than %u bytes, stored on harddisk?",
394	prop_buffer_lengh);	394	G_GNUC_PRETTY_FUNCTION, prop_buffer_lengh);
395	abort++;	395	abort++;
396	}	396	}
397	if (!abort && expected_format && expected_format != format_returned)	397	if (!abort && expected_format && expected_format != format_returned)
398	{	398	{
399	g_warning (G_GNUC_PRETTY_FUNCTION "(): Expected format (%u) unmatched (%d), programmer was drunk?",	399	g_warning ("%s(): Expected format (%u) unmatched (%d), programmer was drunk?",
400	expected_format, format_returned);	400	G_GNUC_PRETTY_FUNCTION, expected_format, format_returned);
401	abort++;	401	abort++;
402	}	402	}
403	if (!abort && prop_data && nitems_return && format_returned)	403	if (!abort && prop_data && nitems_return && format_returned)
Lines 648-654 get_task_root_and_frame (GwmhTask *task) Link Here
648	xframe = None;	648	xframe = None;
649	/* aparently this can happen if a window is destructed shortly after	649	/* aparently this can happen if a window is destructed shortly after
650	* creation, just be silent.	650	* creation, just be silent.
651	* g_warning (G_GNUC_PRETTY_FUNCTION "(): task window id %ld invalid?", task->xwin);	651	* g_warning ("%s(): task window id %ld invalid?",
		652	* G_GNUC_PRETTY_FUNCTION, task->xwin);
652	*/	653	*/
653	}	654	}
654		655
Lines 1586-1593 gwmh_desk_notifier_remove (guint id) Link Here
1586	g_return_if_fail (id > 0);	1587	g_return_if_fail (id > 0);
1587		1588
1588	if (!g_hook_destroy (&gwmh_desk_hook_list, id))	1589	if (!g_hook_destroy (&gwmh_desk_hook_list, id))
1589	g_warning (G_GNUC_PRETTY_FUNCTION "(): unable to remove notifier (%d)",	1590	g_warning ("%s(): unable to remove notifier (%d)",
1590	id);	1591	G_GNUC_PRETTY_FUNCTION, id);
1591	}	1592	}
1592		1593
1593	void	1594	void
Lines 1596-1603 gwmh_task_notifier_remove (guint id) Link Here
1596	g_return_if_fail (id > 0);	1597	g_return_if_fail (id > 0);
1597		1598
1598	if (!g_hook_destroy (&gwmh_task_hook_list, id))	1599	if (!g_hook_destroy (&gwmh_task_hook_list, id))
1599	g_warning (G_GNUC_PRETTY_FUNCTION "(): unable to remove notifier (%d)",	1600	g_warning ("%s(): unable to remove notifier (%d)",
1600	id);	1601	G_GNUC_PRETTY_FUNCTION, id);
1601	}	1602	}
1602		1603
1603	static gboolean	1604	static gboolean
Lines 1624-1631 gwmh_desk_notifier_remove_func (GwmhDesk Link Here
1624	if (hook)	1625	if (hook)
1625	g_hook_destroy_link (&gwmh_desk_hook_list, hook);	1626	g_hook_destroy_link (&gwmh_desk_hook_list, hook);
1626	else	1627	else
1627	g_warning (G_GNUC_PRETTY_FUNCTION "(): unable to remove notifier <%p> (%p)",	1628	g_warning ("%s(): unable to remove notifier <%p> (%p)",
1628	func, func_data);	1629	G_GNUC_PRETTY_FUNCTION, func, func_data);
1629	}	1630	}
1630		1631
1631	void	1632	void
Lines 1643-1650 gwmh_task_notifier_remove_func (GwmhTask Link Here
1643	if (hook)	1644	if (hook)
1644	g_hook_destroy_link (&gwmh_task_hook_list, hook);	1645	g_hook_destroy_link (&gwmh_task_hook_list, hook);
1645	else	1646	else
1646	g_warning (G_GNUC_PRETTY_FUNCTION "(): unable to remove notifier <%p> (%p)",	1647	g_warning ("%s(): unable to remove notifier <%p> (%p)",
1647	func, func_data);	1648	G_GNUC_PRETTY_FUNCTION, func, func_data);
1648	}	1649	}
1649		1650
1650	static gboolean	1651	static gboolean

Lines 322-340 get_typed_property_data (Display *xdispl Link Here

(-)gnome-core-1.4.2/panel/xstuff.c.orig (-5 / +6 lines)
322	requested_type != AnyPropertyType &&	322	requested_type != AnyPropertyType &&
323	requested_type != type_returned)	323	requested_type != type_returned)
324	{	324	{
325	g_warning (G_GNUC_PRETTY_FUNCTION "(): Property has wrong type, probably on crack");	325	g_warning ("%s(): Property has wrong type, probably on crack",
		326	G_GNUC_PRETTY_FUNCTION);
326	abort++;	327	abort++;
327	}	328	}
328	if (!abort && bytes_after_return)	329	if (!abort && bytes_after_return)
329	{	330	{
330	g_warning (G_GNUC_PRETTY_FUNCTION "(): Eeek, property has more than %u bytes, stored on harddisk?",	331	g_warning ("%s(): Eeek, property has more than %u bytes, stored on harddisk?",
331	prop_buffer_lengh);	332	G_GNUC_PRETTY_FUNCTION, prop_buffer_lengh);
332	abort++;	333	abort++;
333	}	334	}
334	if (!abort && expected_format && expected_format != format_returned)	335	if (!abort && expected_format && expected_format != format_returned)
335	{	336	{
336	g_warning (G_GNUC_PRETTY_FUNCTION "(): Expected format (%u) unmatched (%d), programmer was drunk?",	337	g_warning ("%s(): Expected format (%u) unmatched (%d), programmer was drunk?",
337	expected_format, format_returned);	338	G_GNUC_PRETTY_FUNCTION, expected_format, format_returned);
338	abort++;	339	abort++;
339	}	340	}
340	if (!abort && prop_data && nitems_return && format_returned)	341	if (!abort && prop_data && nitems_return && format_returned)