[patch] patch

chromium-107-v8-inline.patch (text/plain), 1.37 KB, created by Stephan Hartmann (RETIRED) on 2022-10-02 14:55:46 UTC

From 620388b1a6445f88fbe7c19ce4041c70eb948d21 Mon Sep 17 00:00:00 2001
From: Clemens Backes <[e-mail]>
Date: Fri, 03 Jun 2022 18:49:41 +0200
Subject: [PATCH] [heap] Fix GCC compilation

Using the constexpr {value()} accessor instead of the non-constexpr
implicit conversion operator makes GCC recognize the method as inlinable
again.
Before, we got (shortened):
  heap/heap-allocator-inl.h:167:18: error: inlining failed in call to
  always_inline ‘HeapAllocator::AllocateRaw’: function not inlinable

The issue was introduced by https://crrev.com/c/3683321.

R=[e-mail]

Bug: v8:12887
Change-Id: I5879dc0afb23d1d5bb782bf9444703e9cba148f1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3688515
Reviewed-by: Adam Klein <[e-mail]>
Commit-Queue: Adam Klein <[e-mail]>
Cr-Commit-Position: refs/heads/main@{#80947}
---

diff --git a/src/heap/heap-allocator-inl.h b/src/heap/heap-allocator-inl.h
index 4bc6d25..06c4648 100644
--- a/src/heap/heap-allocator-inl.h
+++ b/src/heap/heap-allocator-inl.h
@@ -63,7 +63,7 @@
   DCHECK(AllowHandleAllocation::IsAllowed());
   DCHECK(AllowHeapAllocation::IsAllowed());
 
-  if (FLAG_single_generation && type == AllocationType::kYoung) {
+  if (FLAG_single_generation.value() && type == AllocationType::kYoung) {
     return AllocateRaw(size_in_bytes, AllocationType::kOld, origin, alignment);
   }