[patch] Moves usermod to games_post_inst(), suggests moving other code

games.patch (text/plain), 1.36 KB, created by Alec Warner (RETIRED) on 2005-03-04 18:54:09 UTC

--- games.eclass	2005-03-04 21:46:39.462544552 -0500
+++ games.eclass.new	2005-03-04 21:50:34.199859056 -0500
@@ -133,16 +133,13 @@
 }
 
 games_pkg_setup() {
+	# This stuff will probably break sandbox assuming it gets run.  You can move it to pre-inst and it wili be ok
+	# Relevant to bug 84146 ( sandbox violations ). 
 	enewgroup "${GAMES_GROUP}" 35
 	[[ ${GAMES_USER} != "root" ]] \
 		&& enewuser "${GAMES_USER}" 35 /bin/false /usr/games "${GAMES_GROUP}"
 	[[ ${GAMES_USER_DED} != "root" ]] \
 		&& enewuser "${GAMES_USER_DED}" 36 /bin/bash /usr/games "${GAMES_GROUP}"
-
-	# Dear carpaski and portage-dev team, we are so sorry.  Lots of love, games team
-	# See Bug #61680
-	[[ $(getent passwd "${GAMES_USER_DED}" | cut -f7 -d:) == "/bin/false" ]] \
-		&& usermod -s /bin/bash "${GAMES_USER_DED}" 
 }
 
 games_src_compile() {
@@ -153,6 +150,13 @@
 # pkg_postinst function ... create env.d entry and warn about games group
 games_pkg_postinst() {
 	gamesenv
+        # Dear carpaski and portage-dev team, we are so sorry.  Lots of love, games team
+        # See Bug #61680
+	# This breaks sandbox.
+	# See bug #84146 *tongue in cheek*
+        [[ $(getent passwd "${GAMES_USER_DED}" | cut -f7 -d:) == "/bin/false" ]] \
+                && usermod -s /bin/bash "${GAMES_USER_DED}"
+
 	ewarn "Remember, in order to play games, you have to"
 	ewarn "be in the '${GAMES_GROUP}' group."
 	echo