[patch] Exposes --enable-printpipe through ./configure

0001-Define-PRINTPIPE-during-configuration.patch (text/plain), 5.78 KB, created by Renato Alves on 2016-06-02 16:25:33 UTC

From 121986bbbface31eb5927d22389d81abd6f14ad8 Mon Sep 17 00:00:00 2001
From: Renato Alves <[e-mail]>
Date: Thu, 2 Jun 2016 18:09:18 +0200
Subject: [PATCH] Define PRINTPIPE during configuration

PRINTPIPE defines if the "Print to pipe" functionality by pressing the
PrintScreen key is enabled.
By default, this feature sends the terminal content to lpr which in turn
sends it to the printer. To an unaware user, this could result in
accidental printing (to an actual printer) of sensitive information.

This patch allows enabling/disabling this behavior by passing
--(dis|en)able-printpipe to ./configure
---
 config.h.in   |  4 ++++
 configure     | 18 ++++++++++++++++++
 configure.ac  | 12 ++++++++++++
 src/feature.h |  5 -----
 4 files changed, 34 insertions(+), 5 deletions(-)

diff --git a/config.h.in b/config.h.in
index 914d606..096fd1b 100644
--- a/config.h.in
+++ b/config.h.in
@@ -322,6 +322,10 @@
 /* Define if you want to hide the pointer while typing */
 #undef POINTER_BLANK
 
+/* Define if you want PrintScreen to send terminal contents to a pipe (default
+   is to send to printer via lpr) */
+#undef PRINTPIPE
+
 /* Define to a fallback location of lastlogx */
 #undef PT_LASTLOGX_FILE
 
diff --git a/configure b/configure
index 3e3f78b..7bb0526 100755
--- a/configure
+++ b/configure
@@ -721,6 +721,7 @@ enable_pixbuf
 enable_startup_notification
 enable_transparency
 enable_fading
+enable_printpipe
 enable_rxvt_scroll
 enable_next_scroll
 enable_xterm_scroll
@@ -1394,6 +1395,7 @@ Optional Features:
   --enable-startup-notification  enable freedesktop startup notification support
   --enable-transparency   enable transparent backgrounds
   --enable-fading         enable colors fading when off focus
+  --enable-printpipe      enable sending terminal content to a pipe by hitting PrintScreen
   --enable-rxvt-scroll    enable rxvt style scrollbar
   --enable-next-scroll    enable NeXT style scrollbar
   --enable-xterm-scroll   enable Xterm style scrollbar
@@ -4730,6 +4732,7 @@ fi
 support_frills=yes
 support_inheritpixmap=yes
 support_fading=yes
+support_printpipe=yes
 support_keepscrolling=yes
 support_selectionscrolling=yes
 support_mousewheel=yes
@@ -4759,6 +4762,7 @@ if test "${enable_everything+set}" = set; then :
        support_frills=no
        support_inheritpixmap=no
        support_fading=no
+       support_printpipe=no
        support_keepscrolling=no
        support_selectionscrolling=no
        support_lastlog=no
@@ -4787,6 +4791,7 @@ if test "${enable_everything+set}" = set; then :
        support_frills=yes
        support_inheritpixmap=yes
        support_fading=yes
+       support_printpipe=yes
        support_keepscrolling=yes
        support_selectionscrolling=yes
        support_lastlog=yes
@@ -4941,6 +4946,14 @@ if test "${enable_fading+set}" = set; then :
 fi
 
 
+# Check whether --enable-printpipe was given.
+if test "${enable_printpipe+set}" = set; then :
+  enableval=$enable_printpipe; if test x$enableval = xyes -o x$enableval = xno; then
+    support_printpipe=$enableval
+  fi
+fi
+
+
 # Check whether --enable-rxvt-scroll was given.
 if test "${enable_rxvt_scroll+set}" = set; then :
   enableval=$enable_rxvt_scroll; if test x$enableval = xyes -o x$enableval = xno; then
@@ -7749,6 +7762,11 @@ if test x$support_fading = xyes; then
 $as_echo "#define OFF_FOCUS_FADING 1" >>confdefs.h
 
 fi
+if test x$support_printpipe = xyes; then
+
+$as_echo "#define PRINTPIPE \"lpr\"" >>confdefs.h
+
+fi
 if test x$support_keepscrolling = xno; then
 
 $as_echo "#define NO_SCROLLBAR_BUTTON_CONTINUAL_SCROLLING 1" >>confdefs.h
diff --git a/configure.ac b/configure.ac
index 0da3b59..e870b16 100644
--- a/configure.ac
+++ b/configure.ac
@@ -78,6 +78,7 @@ AC_SEARCH_LIBS(socket,        socket)
 support_frills=yes
 support_inheritpixmap=yes
 support_fading=yes
+support_printpipe=yes
 support_keepscrolling=yes
 support_selectionscrolling=yes
 support_mousewheel=yes
@@ -111,6 +112,7 @@ AC_ARG_ENABLE(everything,
        support_frills=no
        support_inheritpixmap=no
        support_fading=no
+       support_printpipe=no
        support_keepscrolling=no
        support_selectionscrolling=no
        support_lastlog=no
@@ -139,6 +141,7 @@ AC_ARG_ENABLE(everything,
        support_frills=yes
        support_inheritpixmap=yes
        support_fading=yes
+       support_printpipe=yes
        support_keepscrolling=yes
        support_selectionscrolling=yes
        support_lastlog=yes
@@ -249,6 +252,12 @@ AC_ARG_ENABLE(fading,
     support_fading=$enableval
   fi])
 
+AC_ARG_ENABLE(printpipe,
+  [  --enable-printpipe      enable sending terminal content to a pipe by hitting PrintScreen],
+  [if test x$enableval = xyes -o x$enableval = xno; then
+    support_printpipe=$enableval
+  fi])
+
 AC_ARG_ENABLE(rxvt-scroll,
   [  --enable-rxvt-scroll    enable rxvt style scrollbar],
   [if test x$enableval = xyes -o x$enableval = xno; then
@@ -657,6 +666,9 @@ fi
 if test x$support_fading = xyes; then
   AC_DEFINE(OFF_FOCUS_FADING, 1, Define if you want faded colors when focus is lost)
 fi
+if test x$support_printpipe = xyes; then
+  AC_DEFINE(PRINTPIPE, "lpr", Define if you want PrintScreen to send terminal contents to a pipe (default is to send to printer via lpr))
+fi
 if test x$support_keepscrolling = xno; then
   AC_DEFINE(NO_SCROLLBAR_BUTTON_CONTINUAL_SCROLLING, 1, Define for continual scrolling when you keep the scrollbar button pressed)
 fi
diff --git a/src/feature.h b/src/feature.h
index 39e080e..9c1897c 100644
--- a/src/feature.h
+++ b/src/feature.h
@@ -331,11 +331,6 @@
 #define COLOR_CURSOR_BACKGROUND	NULL	/* if NULL, use foreground colour */
 
 /*
- * Printer pipe which will be used for emulation of attached vt100 printer
- */
-#define PRINTPIPE	"lpr"
-
-/*
  * Define defaults for backspace and delete keys - unless they have been
  * configured out with --disable-backspace-key / --disable-delete-key
  */
-- 
2.7.4