Go to:
Gentoo Home
Documentation
Forums
Lists
Bugs
Planet
Store
Wiki
Get Gentoo!
Gentoo's Bugzilla – Attachment 330690 Details for
Bug 444876
x11-drivers/xf86-input-synaptics-1.6.2-r1 - Outdated reset-num_active_touches.patch - Hunk #2 FAILED at 3119. -- saving rejects to file src/synaptics.c.rej
Home
|
New
–
[Ex]
|
Browse
|
Search
|
Privacy Policy
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch without the second part
xf86-input-synaptics-1.6.2-reset-num_active_touches.patch (text/plain), 1.41 KB, created by
Alessandro Di Federico
on 2012-11-26 22:37:28 UTC
(
hide
)
Description:
Patch without the second part
Filename:
MIME Type:
Creator:
Alessandro Di Federico
Created:
2012-11-26 22:37:28 UTC
Size:
1.41 KB
patch
obsolete
>From eae444eb1a85d2401501d29f9a6c654c046f806b Mon Sep 17 00:00:00 2001 >From: Peter Hutterer <peter.hutterer@who-t.net> >Date: Thu, 30 Aug 2012 06:38:38 +0000 >Subject: Reset num_active_touches on DeviceOff (#52496) > >When disabling the device, reset num_active_touches to zero. Otherwise, >num_active_touches stays at the value it was on DeviceOff(). Future touches >add to that value until the index may go past priv->open_slots[]. >That causes spurious memory corruption on touch ends. > >And as of 55fc42e7c9b4948cadd4f98ef7b6a3b12e268e3e we ignore pre-existing >touches anyway. > >Test-case: >- place num_touches fingers on the touchpad >- xinput disable <device> >- lift fingers >- xinput enable <device> >- place finger on device, num_active_touches is now (num_touches + 1) > >X.Org Bug 52496 <http://bugs.freedesktop.org/show_bug.cgi?id=52496> > >Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> >Reviewed-by: Chase Douglas <chase.douglas@canonical.com> >(cherry picked from commit a245d42f53096b1ae81e6702729f97ca508e5b5b) > >Conflicts: > src/synaptics.c >--- >diff --git a/src/synaptics.c b/src/synaptics.c >index cd9f936..a28e984 100644 >--- a/src/synaptics.c >+++ b/src/synaptics.c >@@ -1154,6 +1154,7 @@ SynapticsReset(SynapticsPrivate * priv) > priv->prev_z = 0; > priv->prevFingers = 0; > #ifdef HAVE_MULTITOUCH >+ priv->num_active_touches = 0; > memset(priv->open_slots, 0, priv->num_slots * sizeof(int)); > #endif > } >-- >cgit v0.9.0.2-2-gbebe
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 444876
: 330690