[patch] corrected patch for canonicalize() in libsandbox.c

sandbox-2.2_bug292050_alt2.patch (text/plain), 881 bytes, created by Fredric Johansson on 2010-04-22 16:59:35 UTC

diff -rau sandbox-2.2_old/libsandbox/libsandbox.c sandbox-2.2/libsandbox/libsandbox.c
--- sandbox-2.2_old/libsandbox/libsandbox.c	2010-04-22 18:56:04.232191411 +0200
+++ sandbox-2.2/libsandbox/libsandbox.c	2010-04-22 18:57:09.224082423 +0200
@@ -171,7 +171,9 @@
 		size_t len = strlen(resolved_path);
 		snprintf(resolved_path + len, SB_PATH_MAX - len, "/%s", path);
 
-		if (NULL == erealpath(resolved_path, resolved_path)) {
+		char *resolved_path_copy = xmalloc(SB_PATH_MAX);
+		strcpy(resolved_path_copy, resolved_path);
+		if (NULL == erealpath(resolved_path_copy, resolved_path)) {
 			if (errno_is_too_long()) {
 				/* The resolved path is too long for the buffer to hold */
 				return -1;
@@ -181,6 +183,7 @@
 				return -1;
 			}
 		}
+		free(resolved_path_copy);
 
 	} else if ((NULL == retval) && (path[0] == '/')) {
 		/* Whatever it resolved, is not a valid path */