[patch] Implement meaningful start() error handling

postgresql.init-8.4-error-handling.patch (text/plain), 1.16 KB, created by kfm on 2010-03-21 22:16:46 UTC

--- postgresql.init-8.4	2010-01-26 22:05:25.000000000 +0000
+++ /etc/init.d/postgresql-8.4	2010-03-21 22:08:49.077465660 +0000
@@ -1,7 +1,7 @@
 #!/sbin/runscript
-# Copyright 1999-2009 Gentoo Foundation
+# Copyright 1999-2010 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/dev-db/postgresql-server/files/postgresql.init-8.4,v 1.4 2010/01/26 22:01:21 patrick Exp $
+# $Header: $
 
 opts="${opts} reload"
 
@@ -32,12 +32,17 @@
 	fi
 
 	local retval
+	local errmsg
 
-	su -l ${PGUSER} \
-		-c "env PGDATA=\"${PGDATA}\" ${PG_EXTRA_ENV} /usr/lib/postgresql-8.4/bin/pg_ctl start ${WAIT_FOR_START} \
-		-o '--silent-mode=true ${PGOPTS}'"
+	errmsg=$(su -l ${PGUSER} \
+		 -c "env PGDATA=\"${PGDATA}\" /usr/lib/postgresql-8.4/bin/pg_ctl start ${WAIT_FOR_START} \
+		 -o '-d 1 ${PGOPTS}' 1>/dev/null")
 	retval=$?
-	[ $retval -ne 0 ] && eend $retval && return $retval
+
+	if [ $retval -ne 0 ] ; then
+		eend $retval $errmsg
+		return $retval
+	fi
 
 	# The following is to catch the case of an already running server
 	# in which pg_ctl doesn't know to which server it connected to and false reports the server as 'up'