[patch] Quick patch to fix this issue

pls-parser-off-by-one-bug.patch (text/plain), 1.25 KB, created by Michał Mirosław on 2010-02-27 17:21:22 UTC

diff -urN mplayer-1.0_rc4_p20100213/playtreeparser.c mplayer-1.0_rc4_p20100213.new/playtreeparser.c
--- mplayer-1.0_rc4_p20100213/playtreeparser.c	2010-01-31 00:24:23.000000000 +0100
+++ mplayer-1.0_rc4_p20100213.new/playtreeparser.c	2010-02-27 17:53:04.000000000 +0100
@@ -249,7 +249,7 @@
   }
 
   num = atoi(line);
-  if(num < 0) {
+  if(num <= 0) {
     num = max_entry+1;
     mp_msg(MSGT_PLAYTREE,MSGL_WARN,"No entry index in entry %s\nAssuming %d\n",line,num);
   }
@@ -307,19 +307,19 @@
     }
     if(strncasecmp(line,"File",4) == 0) {
       num = pls_read_entry(line+4,&entries,&max_entry,&v);
-      if(num < 0)
+      if(num <= 0)
 	mp_msg(MSGT_PLAYTREE,MSGL_ERR,"No value in entry %s\n",line);
       else
 	entries[num-1].file = strdup(v);
     } else if(strncasecmp(line,"Title",5) == 0) {
       num = pls_read_entry(line+5,&entries,&max_entry,&v);
-      if(num < 0)
+      if(num <= 0)
 	mp_msg(MSGT_PLAYTREE,MSGL_ERR,"No value in entry %s\n",line);
       else
 	entries[num-1].title = strdup(v);
     } else if(strncasecmp(line,"Length",6) == 0) {
       num = pls_read_entry(line+6,&entries,&max_entry,&v);
-      if(num < 0)
+      if(num <= 0)
 	mp_msg(MSGT_PLAYTREE,MSGL_ERR,"No value in entry %s\n",line);
       else
 	entries[num-1].length = strdup(v);