[patch] kmail-3.5.6-crash-svn-643369.patch

kmail-3.5.6-crash-svn-643369.patch (text/plain), 958 bytes, created by Peter Alfredsen (RETIRED) on 2007-03-18 14:57:53 UTC

http://websvn.kde.org/?view=rev&revision=643369

Revision 643369 - (view) (download) (as text) (annotate) - [select for diffs] 
 Modified Sat Mar 17 02:16:46 2007 UTC (32 hours, 41 minutes ago) by winterz 
File length: 11631 byte(s) 
Diff to previous 614050 
backport SVN commit 643168 by coolo:

this looks crashy (and I guess this is the same with 3.5) (CID 3205)

--- branches/KDE/3.5/kdepim/kmail/customtemplates.cpp	2006/12/16 04:47:10	614050
+++ branches/KDE/3.5/kdepim/kmail/customtemplates.cpp	2007/03/17 02:16:46	643369
@@ -300,9 +300,10 @@
   if ( mCurrentItem ) {
     // mCurrentItem->setText( 0, indexToType( index ) );
     CustomTemplateItem *vitem = mItemList[ mCurrentItem->text( 1 ) ];
-    if ( vitem ) {
-      vitem->mType = static_cast<Type>(index);
+    if ( !vitem ) {
+      return;
     }
+    vitem->mType = static_cast<Type>(index);
     switch ( vitem->mType ) {
     case TReply:
       mCurrentItem->setPixmap( 0, mReplyPix );