Go to:
Gentoo Home
Documentation
Forums
Lists
Bugs
Planet
Store
Wiki
Get Gentoo!
Gentoo's Bugzilla – Attachment 113648 Details for
Bug 171346
[PATCH] kde-base/kmail-3.5.6-r1: Fixes for various crash and hang bugs
Home
|
New
–
[Ex]
|
Browse
|
Search
|
Privacy Policy
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
kmail-3.5.6-crash-unfixed-filter-mails.patch
kmail-3.5.6-crash-unfixed-filter-mails.patch (text/plain), 1.66 KB, created by
Peter Alfredsen (RETIRED)
on 2007-03-18 14:52:36 UTC
(
hide
)
Description:
kmail-3.5.6-crash-unfixed-filter-mails.patch
Filename:
MIME Type:
Creator:
Peter Alfredsen (RETIRED)
Created:
2007-03-18 14:52:36 UTC
Size:
1.66 KB
patch
obsolete
>http://bugs.debian.org/404032 -> >http://bugs.kde.org/139886 -> >http://bugs.kde.org/128593 -> >http://bugs.kde.org/108971 > >Status: Still not merged upstream > >Bug#404032: kmail: crash when filtering mails into current folder >Michael Eyrich >Tue, 06 Feb 2007 08:26:00 -0800 >Package: kmail >Version: 4:3.5.5.dfsg.1-6 >Followup-For: Bug #404032 > >It looks like kmail does not honour multiple opens of the same mailbox >thus closing the current mailbox unmindful and crashes. > >the attached (dirty) patch avoids closing a folder if already open. > >Index: kmail/kmfilteraction.cpp >=================================================================== >--- kdepim/kmail/kmfilteraction.cpp (revision 539146) >+++ kdepim/kmail/kmfilteraction.cpp (working copy) >@@ -1373,12 +1373,21 @@ > > KMFilterAction::ReturnCode KMFilterActionCopy::process(KMMessage* msg) const > { >+ bool opened = false; >+ > // TODO opening and closing the folder is a trade off. > // Perhaps Copy is a seldomly used action for now, > // but I gonna look at improvements ASAP. >- if ( !mFolder && mFolder->open() != 0 ) >- return ErrorButGoOn; >- >+ if ( !mFolder ) { >+ if (!mFolder->isOpened()) { >+ int rc; >+ opened = true; >+ rc = mFolder->open(); >+ kdDebug(5006) << "KMFolderMaildir::addMsg-open: " << rc << " of folder: " << label() << endl; >+ if (rc) return ErrorButGoOn; >+ } >+ } >+ > // copy the message 1:1 > KMMessage* msgCopy = new KMMessage; > msgCopy->fromDwString(msg->asDwString()); >@@ -1387,8 +1396,9 @@ > int rc = mFolder->addMsg(msgCopy, &index); > if (rc == 0 && index != -1) > mFolder->unGetMsg( index ); >- mFolder->close(); > >+ if (opened) mFolder->close(); >+ > return GoOn; > } >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 171346
: 113648 |
113652
|
113654
|
113657
|
113658
|
113659
|
113660
|
113703
|
113704
|
115351
|
115548