Attachment #260796 for bug #262365

Lines 363-368 qahelp={ Link Here

(-)a/bin/repoman (+2 lines)
363	"metadata.missing":"Missing metadata.xml files",	363	"metadata.missing":"Missing metadata.xml files",
364	"metadata.bad":"Bad metadata.xml files",	364	"metadata.bad":"Bad metadata.xml files",
365	"metadata.warning":"Warnings in metadata.xml files",	365	"metadata.warning":"Warnings in metadata.xml files",
		366	"portage.internal":"The ebuild uses an internal Portage function",
366	"virtual.versioned":"PROVIDE contains virtuals with versions",	367	"virtual.versioned":"PROVIDE contains virtuals with versions",
367	"virtual.exists":"PROVIDE contains existing package names",	368	"virtual.exists":"PROVIDE contains existing package names",
368	"virtual.unavailable":"PROVIDE contains a virtual which contains no profile default",	369	"virtual.unavailable":"PROVIDE contains a virtual which contains no profile default",
Lines 409-414 qawarnings = set(( Link Here
409	"java.eclassesnotused",	410	"java.eclassesnotused",
410	"wxwidgets.eclassnotused",	411	"wxwidgets.eclassnotused",
411	"metadata.warning",	412	"metadata.warning",
		413	"portage.internal",
412	"virtual.versioned",	414	"virtual.versioned",
413	"virtual.exists",	415	"virtual.exists",
414	"virtual.unavailable",	416	"virtual.unavailable",




			return 'WANT_AUTO' + m.group(1) + \
				' redundantly set to default value "latest" on line: %d'

class PortageInternal(LineCheck):
	"""
	In February 2009 the Gentoo council ruled that
	prepalldocs is a Portage internal.
	"""
	repoman_check_name = 'portage.internal'
	re = re.compile(r'[^#]*\bprepalldocs\b')
	error = errors.PREPALLDOCS_ERROR

class SrcCompileEconf(PhaseCheck):
	repoman_check_name = 'ebuild.minorsyn'
	configure_re = re.compile(r'\s(econf|./configure)')

	ImplicitRuntimeDeps, InheritAutotools, InheritDeprecated, IUseUndefined,
	EMakeParallelDisabled, EMakeParallelDisabledViaMAKEOPTS, NoAsNeeded,
	DeprecatedBindnowFlags, SrcUnpackPatches, WantAutoDefaultValue,
	PortageInternal, SrcCompileEconf, Eapi3DeprecatedFuncs,
	Eapi4IncompatibleFuncs, Eapi4GoneVars, BuiltWithUse,
	PreserveOldLib, SandboxAddpredict)))


Lines 15-20 REDUNDANT_CD_S_ERROR = 'Ebuild has redundant cd ${S} statement on line: %d' Link Here

(-)a/pym/repoman/errors.py (-1 / +1 lines)
15	EMAKE_PARALLEL_DISABLED = 'Upstream parallel compilation bug (ebuild calls emake -j1 on line: %d)'	15	EMAKE_PARALLEL_DISABLED = 'Upstream parallel compilation bug (ebuild calls emake -j1 on line: %d)'
16	EMAKE_PARALLEL_DISABLED_VIA_MAKEOPTS = 'Upstream parallel compilation bug (MAKEOPTS=-j1 on line: %d)'	16	EMAKE_PARALLEL_DISABLED_VIA_MAKEOPTS = 'Upstream parallel compilation bug (MAKEOPTS=-j1 on line: %d)'
17	DEPRECATED_BINDNOW_FLAGS = 'Deprecated bindnow-flags call on line: %d'	17	DEPRECATED_BINDNOW_FLAGS = 'Deprecated bindnow-flags call on line: %d'
		18	PREPALLDOCS_ERROR = 'prepalldocs called on line: %d'
18	EAPI_DEFINED_AFTER_INHERIT = 'EAPI defined after inherit on line: %d'	19	EAPI_DEFINED_AFTER_INHERIT = 'EAPI defined after inherit on line: %d'
19	NO_AS_NEEDED = 'Upstream asneeded linking bug (no-as-needed on line: %d)'	20	NO_AS_NEEDED = 'Upstream asneeded linking bug (no-as-needed on line: %d)'
20	PRESERVE_OLD_LIB = 'Upstream ABI change workaround on line: %d'	21	PRESERVE_OLD_LIB = 'Upstream ABI change workaround on line: %d'
21	-

Return to bug 262365

Lines 536-541 class WantAutoDefaultValue(LineCheck): Link Here

(-)a/pym/repoman/checks.py (-1 / +10 lines)
536	return 'WANT_AUTO' + m.group(1) + \	536	return 'WANT_AUTO' + m.group(1) + \
537	' redundantly set to default value "latest" on line: %d'	537	' redundantly set to default value "latest" on line: %d'
538		538
		539	class PortageInternal(LineCheck):
		540	"""
		541	In February 2009 the Gentoo council ruled that
		542	prepalldocs is a Portage internal.
		543	"""
		544	repoman_check_name = 'portage.internal'
		545	re = re.compile(r'[^#]*\bprepalldocs\b')
		546	error = errors.PREPALLDOCS_ERROR
		547
539	class SrcCompileEconf(PhaseCheck):	548	class SrcCompileEconf(PhaseCheck):
540	repoman_check_name = 'ebuild.minorsyn'	549	repoman_check_name = 'ebuild.minorsyn'
541	configure_re = re.compile(r'\s(econf\|./configure)')	550	configure_re = re.compile(r'\s(econf\|./configure)')
Lines 622-628 _constant_checks = tuple((c() for c in ( Link Here
622	ImplicitRuntimeDeps, InheritAutotools, InheritDeprecated, IUseUndefined,	631	ImplicitRuntimeDeps, InheritAutotools, InheritDeprecated, IUseUndefined,
623	EMakeParallelDisabled, EMakeParallelDisabledViaMAKEOPTS, NoAsNeeded,	632	EMakeParallelDisabled, EMakeParallelDisabledViaMAKEOPTS, NoAsNeeded,
624	DeprecatedBindnowFlags, SrcUnpackPatches, WantAutoDefaultValue,	633	DeprecatedBindnowFlags, SrcUnpackPatches, WantAutoDefaultValue,
625	SrcCompileEconf, Eapi3DeprecatedFuncs,	634	PortageInternal, SrcCompileEconf, Eapi3DeprecatedFuncs,
626	Eapi4IncompatibleFuncs, Eapi4GoneVars, BuiltWithUse,	635	Eapi4IncompatibleFuncs, Eapi4GoneVars, BuiltWithUse,
627	PreserveOldLib, SandboxAddpredict)))	636	PreserveOldLib, SandboxAddpredict)))
628		637