91044 – gaim with use-flag nas failes to compile with gcc-4.0.0

Bug 91044 - gaim with use-flag nas failes to compile with gcc-4.0.0

Summary: gaim with use-flag nas failes to compile with gcc-4.0.0

Status:	RESOLVED TEST-REQUEST

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Unspecified (show other bugs)
Hardware:	All All

Importance:	High normal (vote)
Assignee:	Gaim Bugs Crew

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2005-05-01 05:41 UTC by Kristiaan Lenaerts
Modified:	2005-07-21 02:16 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
patch (gaim-1.2.1-gcc4.patch,394 bytes, patch) 2005-05-01 05:42 UTC, Kristiaan Lenaerts	Details \| Diff
modified ebuild (gaim-1.2.1.ebuild,4.07 KB, text/plain) 2005-05-01 05:43 UTC, Kristiaan Lenaerts	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Kristiaan Lenaerts 2005-05-01 05:41:17 UTC

Gaim 1.2.1 fails to compile with gcc 4.0.0 in file gtksound.c . On line 202 there is an implicit declaration of play_file_nas, and later that function is defined as a static function. This is easily solvable by declaring the function play_file_nas  as static before it is used, this is wath teh attached patch does. I'll attach a modified ebuild as well, the patch is only applied if nas is set as use-flag.

Comment 1 Kristiaan Lenaerts 2005-05-01 05:42:23 UTC

Created attachment 57726 [details, diff]
patch

Comment 2 Kristiaan Lenaerts 2005-05-01 05:43:02 UTC

Created attachment 57727 [details]
modified ebuild

Comment 3 Don Seiler (RETIRED) gentoo-dev

2005-07-20 21:45:33 UTC

I'm told this was fixed in 1.3.0.  Please upgrade to gaim >= 1.3.0 and report back.

Comment 4 Kristiaan Lenaerts 2005-07-21 02:16:23 UTC

I have tested with gaim 1.4, which works fine... the only problem is that nas
itself doesn't compile with gcc 4.0.x, but that's another bug (#91053)