Bug 898540 – sys-apps/baobab-43.0 fails to compile (MUSL-CLANG-SYSTEM): baobab-cellrenderers.c:429:45: error: incompatible function pointer types assigning to void ()(GtkCellRenderer , GtkSnapshot , GtkWidget , const GdkRectangle , const GdkRectangle , GtkCellRendere

• Status: CONFIRMED
• Product: Gentoo Linux

[Description Agostino Sarubbo 2023-03-01 08:07:37 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-apps/baobab-43.0 fails to compile (MUSL-CLANG-SYSTEM).
Discovered on: amd64 (internal ref: tinderbox_musl)

NOTE:
(MUSL-CLANG-SYSTEM) in the summary means that bug was found on a machine that runs MUSL libc + clang16 but this bug MAY or MAY NOT BE related to musl/clang16.

[Comment 1 Agostino Sarubbo 2023-03-01 08:07:40 UTC]

Created attachment 855348 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2023-03-01 08:07:41 UTC]

Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: src/baobab.p/meson-generated_baobab-cellrenderers.c.o 
Program appstream-util found: NO
src/baobab.p/baobab-cellrenderers.c:429:45: error: incompatible function pointer types assigning to 'void (*)(GtkCellRenderer *, GtkSnapshot *, GtkWidget *, const GdkRectangle *, const GdkRectangle *, GtkCellRendererState)' (aka 'void (*)(struct _GtkCellRenderer *, struct _GdkSnapshot *, struct _GtkWidget *, const struct _cairo_rectangle_int *, const struct _cairo_rectangle_int *, GtkCellRendererState)') from 'void (*)(GtkCellRenderer *, GtkSnapshot *, GtkWidget *, GdkRectangle *, GdkRectangle *, GtkCellRendererState)' (aka 'void (*)(struct _GtkCellRenderer *, struct _GdkSnapshot *, struct _GtkWidget *, struct _cairo_rectangle_int *, struct _cairo_rectangle_int *, GtkCellRendererState)') [-Wincompatible-function-pointer-types]

[Comment 3 Matt Turner 2023-05-09 19:39:35 UTC]

I cannot reproduce this.

I'm using

> CHOST="x86_64-pc-linux-gnu"
> CC="${CHOST}-clang"
> CXX="${CHOST}-clang++"
> CFLAGS="${__COMMON_FLAGS}"
> CFLAGS="${CFLAGS} -Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types"

I tried with vala-0.56.4 (which is what this was reported with) and vala-0.56.7. I tried baobab-43.0 and baobab-44.0.

And from the log, the line that fails

>         ((GtkCellRendererClass *) klass)->snapshot = (void (*) (GtkCellRenderer*, GtkSnapshot*, GtkWidget*, GdkRectangle*, GdkRectangle*, GtkCellRendererState)) baobab_cell_renderer_name_real_snapshot;

is exactly the same on my system.

[Comment 4 Matt Turner 2023-05-09 19:43:00 UTC]

I should note that I'm testing with clang-15.0.7 with those CFLAGS, not real clang-16.

[Comment 5 Sam James 2023-05-09 19:50:58 UTC]

I wonder if this one got fixed by Vala changes then? Your test env sounds fine

[Comment 6 listout 2023-05-12 05:03:06 UTC]

(In reply to Matt Turner from comment #3)
> I cannot reproduce this.
> 
> I'm using
> 
> > CHOST="x86_64-pc-linux-gnu"
> > CC="${CHOST}-clang"
> > CXX="${CHOST}-clang++"
> > CFLAGS="${__COMMON_FLAGS}"
> > CFLAGS="${CFLAGS} -Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types"
> 
> I tried with vala-0.56.4 (which is what this was reported with) and
> vala-0.56.7. I tried baobab-43.0 and baobab-44.0.
> 
> And from the log, the line that fails
> 
> >         ((GtkCellRendererClass *) klass)->snapshot = (void (*) (GtkCellRenderer*, GtkSnapshot*, GtkWidget*, GdkRectangle*, GdkRectangle*, GtkCellRendererState)) baobab_cell_renderer_name_real_snapshot;
> 
> is exactly the same on my system.

I can reproduce the bug even on sys-apps/baobab-44

[Comment 7 listout 2023-05-12 05:27:12 UTC]

Created attachment 861549 [details, diff]
Tempoaray patch

I'm not sure how to apply this patch but it seems to fix the error.