Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 898300 - sci-mathematics/flintqs-1.0 fails to compile (MUSL-CLANG-SYSTEM): QS.cpp:507:6: error: ISO C++17 does not allow register storage class specifier [-Wregister]
Summary: sci-mathematics/flintqs-1.0 fails to compile (MUSL-CLANG-SYSTEM): QS.cpp:507:...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michael Orlitzky
URL: https://github.com/sagemath/FlintQS/p...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-28 09:53 UTC by Agostino Sarubbo
Modified: 2024-03-01 14:50 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,60.29 KB, text/plain)
2023-02-28 09:53 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-02-28 09:53:18 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-mathematics/flintqs-1.0 fails to compile (MUSL-CLANG-SYSTEM).
Discovered on: amd64 (internal ref: tinderbox_musl)

NOTE:
(MUSL-CLANG-SYSTEM) in the summary means that bug was found on a machine that runs MUSL libc + clang16 but this bug MAY or MAY NOT BE related to musl/clang16.
Comment 1 Agostino Sarubbo gentoo-dev 2023-02-28 09:53:20 UTC
Created attachment 855124 [details]
build.log

build log and emerge --info
Comment 2 Michael Orlitzky gentoo-dev 2023-03-24 13:40:29 UTC
Now that I've taken a closer look at the FlintQS code, I think a better plan is to eliminate it entirely. Flint (the library) now has qsieve_factor() built-in, and Frederik (its maintainer) says that FlintQS is probably redundant now, pending some benchmarks.

I also found several silly /tmp vulnerabilities in FlintQS that I'd rather not deal with.

So, I will work on having sage interface with qsieve_factor() directly. At the same time I will add algorithm='flint' as an additional option for sage's factor(), based on fmpz_factor().
Comment 3 Michael Orlitzky gentoo-dev 2023-05-02 23:48:16 UTC
I've removed FlintQS from sage and will soon remove it from Gentoo.
Comment 4 Larry the Git Cow gentoo-dev 2023-07-08 17:40:04 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=30e7a7d6721697db1d8db512f6ef26220f208a21

commit 30e7a7d6721697db1d8db512f6ef26220f208a21
Author:     Jakov Smolić <jsmolic@gentoo.org>
AuthorDate: 2023-07-08 17:20:57 +0000
Commit:     Jakov Smolić <jsmolic@gentoo.org>
CommitDate: 2023-07-08 17:39:47 +0000

    sci-mathematics/flintqs: treeclean
    
    Closes: https://bugs.gentoo.org/898300
    Signed-off-by: Jakov Smolić <jsmolic@gentoo.org>

 profiles/package.mask                      |  5 ----
 sci-mathematics/flintqs/Manifest           |  1 -
 sci-mathematics/flintqs/flintqs-1.0.ebuild | 39 ------------------------------
 sci-mathematics/flintqs/metadata.xml       | 24 ------------------
 4 files changed, 69 deletions(-)