Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 896966 - games-util/sc-controller: needs upgrade to Python 3.11 (PythonCompatUpdate)
Summary: games-util/sc-controller: needs upgrade to Python 3.11 (PythonCompatUpdate)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 896398
  Show dependency tree
 
Reported: 2023-02-25 09:45 UTC by Michał Górny
Modified: 2023-04-11 19:00 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-02-25 09:45:21 UTC 
This package does not support Python 3.11.  Please test it with Python 3.11 as a matter of urgency as the default will change in early June, as per message on gentoo-dev: https://archives.gentoo.org/gentoo-dev/message/abb5788ea81c7bbf4d40a2995b682eb9.  Please check the information provided in the tracker.  Ask in #gentoo-python on IRC if need any help.
Comment 1 James Le Cuirot gentoo-dev 2023-02-28 22:20:35 UTC 
FYI I've briefly tried 3.11 and a couple of tests fail that pass with 3.10. I'll look closer soon.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-04-09 16:01:12 UTC 
Ping.
Comment 3 James Le Cuirot gentoo-dev 2023-04-09 21:55:35 UTC 
It's because Python 3.11 has changed the behaviour of str() on IntEnums. Haven't figured out a good solution yet.
Comment 4 James Le Cuirot gentoo-dev 2023-04-09 21:59:39 UTC 
Now I have. More tomorrow.
Comment 5 James Le Cuirot gentoo-dev 2023-04-10 22:09:01 UTC 
I have a patch and the tests pass now but I want to do some run-time testing as I do use this a lot. At first glance, it looks like there may be a little more breakage, but maybe these are errors I just didn't notice before.
Comment 6 Larry the Git Cow gentoo-dev 2023-04-11 18:49:55 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=683adc3c6adb00fcb54fa3fee43e9ae700063503

commit 683adc3c6adb00fcb54fa3fee43e9ae700063503
Author:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
AuthorDate: 2023-04-11 18:48:50 +0000
Commit:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
CommitDate: 2023-04-11 18:49:46 +0000

    games-util/sc-controller: enable python3.11
    
    Closes: https://bugs.gentoo.org/896966
    Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>

 .../files/sc-controller-0.4.8.9-python3_11.patch   | 24 +++++++++
 .../sc-controller/sc-controller-0.4.8.9-r1.ebuild  | 57 ++++++++++++++++++++++
 2 files changed, 81 insertions(+)
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-04-11 18:54:17 UTC 
Andrew, isn't chewi actively working on this?
Comment 8 Andrew Ammerlaan gentoo-dev 2023-04-11 19:00:26 UTC 
(In reply to James Le Cuirot from comment #5)
> I have a patch and the tests pass now but I want to do some run-time testing
> as I do use this a lot. At first glance, it looks like there may be a little
> more breakage, but maybe these are errors I just didn't notice before.

(In reply to Sam James from comment #7)
> Andrew, isn't chewi actively working on this?

Oh my god, I'm so sorry, I had completely missed the recent comments on this bug. I should have read it properly before pushing.

For what its worth, the patch fixes the py3.11 problem on my end, did some run-time testing and it was working as before with python 3.10.

I'm really sorry, I was in the flow and working too fast.