Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 891683 - dev-cpp/valijson-0.7 adds -Werror flag on its own (LIBARCHIVE-SYSTEM)
Summary: dev-cpp/valijson-0.7 adds -Werror flag on its own (LIBARCHIVE-SYSTEM)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Holger Hoffstätte
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: werror
  Show dependency tree
 
Reported: 2023-01-22 09:40 UTC by Agostino Sarubbo
Modified: 2023-05-27 07:49 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,136.72 KB, text/plain)
2023-01-22 09:40 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-01-22 09:40:48 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-cpp/valijson-0.7 adds -Werror flag on its own (LIBARCHIVE-SYSTEM).
Discovered on: amd64 (internal ref: libarchive_tinderbox)

NOTE:
(LIBARCHIVE-SYSTEM) in the summary means that the bug was found on a machine that runs app-alternatives/tar and app-alternatives/cpio with [-gnu,+libarchive] but this bug MAY or MAY NOT BE related to the tar/cpio implementation.
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.
Comment 1 Agostino Sarubbo gentoo-dev 2023-01-22 09:40:50 UTC
Created attachment 848977 [details]
build.log

build log and emerge --info
Comment 2 Holger Hoffstätte 2023-01-23 10:05:32 UTC
Thanks for the heads-up. We already remove -Werror, but apparently some parts of the vendored test suite add it back. Since the test support will go away with the next update to 1.0 (as upstream has changed its packaging) I'm closing this as WONTFIX. It's really not worth the trouble for a header-only library.
Comment 3 Agostino Sarubbo gentoo-dev 2023-01-23 10:08:45 UTC
(In reply to Holger Hoffstätte from comment #2)
> Since the test support will go away with the next update to 1.0 (as upstream has changed its packaging) I'm
> closing this as WONTFIX.

Let's keep open to avoid duplicates
Comment 4 Larry the Git Cow gentoo-dev 2023-02-08 12:22:43 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=44f039de30123a9472590cc6d2c15aa520a1d82b

commit 44f039de30123a9472590cc6d2c15aa520a1d82b
Author:     Holger Hoffstätte <holger@applied-asynchrony.com>
AuthorDate: 2023-01-23 11:00:05 +0000
Commit:     Viorel Munteanu <ceamac@gentoo.org>
CommitDate: 2023-02-08 12:19:40 +0000

    dev-cpp/valijson: bump to 1.0
    
    This also removes the test support since upstream has removed the vendored
    test dependencies from the tarball in favor of git submodules.
    
    Bug: https://bugs.gentoo.org/891683
    Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
    Closes: https://github.com/gentoo/gentoo/pull/29227
    Signed-off-by: Viorel Munteanu <ceamac@gentoo.org>

 dev-cpp/valijson/Manifest                        |  1 +
 dev-cpp/valijson/files/1.0-fix-macro-typos.patch | 77 ++++++++++++++++++++++++
 dev-cpp/valijson/valijson-1.0.ebuild             | 24 ++++++++
 3 files changed, 102 insertions(+)
Comment 5 Larry the Git Cow gentoo-dev 2023-05-27 07:49:27 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8907498d925ed490841e9208e84c01994316c3af

commit 8907498d925ed490841e9208e84c01994316c3af
Author:     Holger Hoffstätte <holger@applied-asynchrony.com>
AuthorDate: 2023-05-15 09:44:49 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2023-05-27 07:49:18 +0000

    dev-cpp/valijson: clean up old
    
    Can be cleaned up since 1.0 is stable.
    
    Closes: https://bugs.gentoo.org/891683
    Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
    Closes: https://github.com/gentoo/gentoo/pull/31040
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 dev-cpp/valijson/Manifest            |  1 -
 dev-cpp/valijson/valijson-0.7.ebuild | 44 ------------------------------------
 2 files changed, 45 deletions(-)