https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: media-libs/libjxl-0.7.0_pre20220825 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Created attachment 821758 [details] build.log build log and emerge --info
Error(s) that match a know pattern in addition to what has been reported in the summary: FAILED: libjxl_dec.so.0.7.0 /var/tmp/portage/media-libs/libjxl-0.7.0_pre20220825/work/libjxl-libjxl-4c31ef0/lib/jxl/render_pipeline/stage_from_linear.cc:66:8: error: type ‘struct OpHlg’ violates the C++ One Definition Rule [-Werror=odr]
Hi Agostino, I reported to the upstream: https://github.com/libjxl/libjxl/issues/1819
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=26fc3c9a722a0d9847b6127fffaeb6ecacedbfa3 commit 26fc3c9a722a0d9847b6127fffaeb6ecacedbfa3 Author: Daniel Novomeský <dnovomesky@gmail.com> AuthorDate: Mon Oct 17 11:07:49 2022 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: Tue Oct 25 12:13:00 2022 media-libs/libjxl: add 0.7.0 Closes: https://bugs.gentoo.org/876727 Signed-off-by: Daniel Novomeský <dnovomesky@gmail.com> Closes: https://github.com/gentoo/gentoo/pull/27820 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> media-libs/libjxl/Manifest | 1 + media-libs/libjxl/{libjxl-9999.ebuild => libjxl-0.7.0.ebuild} | 35 +++++++++++++++++------------------ media-libs/libjxl/libjxl-9999.ebuild | 12 ++++++------ media-libs/libjxl/metadata.xml | 1 - 4 files changed, 24 insertions(+), 25 deletions(-) copy media-libs/libjxl/{libjxl-9999.ebuild => libjxl-0.7.0.ebuild} (71%)
P.S. (Please include all bugs in Closes. This commit added filter-lto too.) P.P.S. It was fixed upstream in 0.8.0.
