Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 870769 - app-editors/joe: compilation errors with -Werror=strict-prototypes
Summary: app-editors/joe: compilation errors with -Werror=strict-prototypes
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Amy Liffey
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: c99-porting
  Show dependency tree
 
Reported: 2022-09-17 15:06 UTC by Holger Hoffstätte
Modified: 2022-09-17 21:15 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Hoffstätte 2022-09-17 15:06:18 UTC
As expected from this old codebase:

clang -DHAVE_CONFIG_H -I. -I../../joe     -pipe -march=native -O2 -Werror=strict-prototypes -c -o termidx.o termidx.c
In file included from termidx.c:8:
In file included from ../../joe/types.h:297:
../../joe/charmap.h:83:16: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
void joe_locale();
               ^
                void
In file included from termidx.c:8:
In file included from ../../joe/types.h:299:
../../joe/b.h:174:12: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
void brmall();
           ^
            void

and a few more.


Reproducible: Always
Comment 1 Holger Hoffstätte 2022-09-17 15:29:50 UTC
I already fixed this locally and will try sending the patches to upstream.
This is more difficult than expected because it's on SF and uses Mercurial..
Comment 2 Holger Hoffstätte 2022-09-17 15:57:59 UTC
The patch is quite large (13k) so for now I've dropped it into my private overlay. Feel free to borrow:

https://github.com/hhoffstaette/portage/tree/master/app-editors/joe
Comment 3 Holger Hoffstätte 2022-09-17 20:32:00 UTC
Here is the upstream merge request:
https://sourceforge.net/p/joe-editor/mercurial/merge-requests/2/
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-09-17 20:35:54 UTC
(In reply to Holger Hoffstätte from comment #2)
> The patch is quite large (13k) so for now I've dropped it into my private
> overlay. Feel free to borrow:
> 
> https://github.com/hhoffstaette/portage/tree/master/app-editors/joe

Could you whack up a PR and then I'll compress-and-upload the patch myself when merging?
Comment 5 Holger Hoffstätte 2022-09-17 20:54:47 UTC
Will do! Thanks.
Comment 6 Larry the Git Cow gentoo-dev 2022-09-17 21:15:52 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bd879e9e2691b082021eac942d4a982abd43322c

commit bd879e9e2691b082021eac942d4a982abd43322c
Author:     Holger Hoffstätte <holger@applied-asynchrony.com>
AuthorDate: 2022-09-17 21:01:49 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-09-17 21:14:53 +0000

    app-editors/joe: fix build with -Werror=strict-prototypes
    
    Closes: https://bugs.gentoo.org/870769
    Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
    Closes: https://github.com/gentoo/gentoo/pull/27314
    Signed-off-by: Sam James <sam@gentoo.org>

 app-editors/joe/files/joe-4.6-prototypes.patch | 409 +++++++++++++++++++++++++
 app-editors/joe/joe-4.6-r2.ebuild              |  57 ++++
 2 files changed, 466 insertions(+)