https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: media-libs/faad2-2.10.0 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Created attachment 792935 [details] build.log build log and emerge --info
Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
2.10.0 has been just removed. is 2.10.1 still affected?
Created attachment 863018 [details] build log and emerge --info It is still reproducible on 2.10.1
Noticed upstream was pretty active, so I have reported this issue. https://github.com/knik0/faad2/issues/163
Fixed upstream with https://github.com/knik0/faad2/commit/1d539788397713968d9660fe9f4e68af526bab73
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6abca05fd236198f409f23bd6eed74b6a5165de2 commit 6abca05fd236198f409f23bd6eed74b6a5165de2 Author: Alfred Wingate <parona@protonmail.com> AuthorDate: 2023-11-13 08:10:58 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-11-22 17:33:51 +0000 media-libs/faad2: add 2.11.0 Closes: https://bugs.gentoo.org/859844 Closes: https://bugs.gentoo.org/917031 Signed-off-by: Alfred Wingate <parona@protonmail.com> Closes: https://github.com/gentoo/gentoo/pull/33784 Signed-off-by: Sam James <sam@gentoo.org> media-libs/faad2/Manifest | 1 + media-libs/faad2/faad2-2.11.0.ebuild | 36 ++++++++++++ .../faad2-2.11.0-check-if-lrintf-is-defined.patch | 64 ++++++++++++++++++++++ 3 files changed, 101 insertions(+)
