Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 854222 - app-crypt/gnupg-2.3.7-r1 fails to compile (lto): photoid.h:31:6: error: type of [-Werror=lto-type-mismatch]
Summary: app-crypt/gnupg-2.3.7-r1 fails to compile (lto): photoid.h:31:6: error: type ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
: 912233 (view as bug list)
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-06-25 08:26 UTC by Agostino Sarubbo
Modified: 2023-08-14 05:23 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,233.90 KB, text/plain)
2022-06-25 08:26 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-06-25 08:26:27 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-crypt/gnupg-2.3.6 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Comment 1 Agostino Sarubbo gentoo-dev 2022-06-25 08:26:30 UTC
Created attachment 787565 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-07-26 09:00:12 UTC
Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 3 Agostino Sarubbo gentoo-dev 2022-08-15 18:18:35 UTC
lto_tinderbox has reproduced this issue with version 2.3.7-r1 - Updating summary.
Comment 4 Kostadin Shishmanov 2023-08-03 16:45:28 UTC
See also: https://dev.gnupg.org/T4416
Comment 5 Larry the Git Cow gentoo-dev 2023-08-13 08:08:35 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cb7ef59c5e93ae0cc20242c9154160c39e19de45

commit cb7ef59c5e93ae0cc20242c9154160c39e19de45
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-08-13 08:08:15 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-08-13 08:08:15 +0000

    app-crypt/gnupg: filter-lto
    
    Unsupported by upstream and warnings indicating that it's unsafe are unfixed.
    
    Closes: https://bugs.gentoo.org/854222
    Signed-off-by: Sam James <sam@gentoo.org>

 app-crypt/gnupg/gnupg-2.2.41.ebuild   | 3 +++
 app-crypt/gnupg/gnupg-2.4.2-r1.ebuild | 3 +++
 app-crypt/gnupg/gnupg-2.4.3.ebuild    | 3 +++
 3 files changed, 9 insertions(+)
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-08-14 05:23:13 UTC
*** Bug 912233 has been marked as a duplicate of this bug. ***