Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 852779 - net-misc/dahdi-tools-3.1.0-r3 init script outputs errors
Summary: net-misc/dahdi-tools-3.1.0-r3 init script outputs errors
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jaco Kroon
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-06-17 14:08 UTC by Vieri
Modified: 2022-06-30 21:47 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vieri 2022-06-17 14:08:02 UTC
net-misc/dahdi-tools-3.1.0-r3 init script taken from https://github.com/jkroonza/gentoo/tree/dahdi-202206/net-misc/dahdi-tools

I'm seeing the following errors (command not found and No such file or directory) when starting dahdi-autoconf:

# /etc/init.d/dahdi-autoconf start
 * Caching service dependencies ...
 * You are binding an interface in you virtual hosts.
 * You must add rc_need="net.FOO" to your /etc/conf.d/apache2
 * where FOO is the interface(s) providing the following address(es):
 *  *:62000 *:62001 *:62002 *:62003                                                 [ ok ]
 * Found Digium Wildcard B410P at pci:0000:08:05.0 (module: wcb4xxp)
 * Loading module wcb4xxp ...                                                       [ ok ]
 * Found Wildcard TE435/235 at pci:0000:09:00.0 (module: wcte43x)
 * Loading module wcte43x ...                                                       [ ok ]
 * Generating DAHDI Configuration ...
/etc/init.d/dahdi-autoconf: line 179: 2: command not found
/etc/init.d/dahdi-autoconf: line 179: 3: command not found
/etc/init.d/dahdi-autoconf: line 179: 4: command not found
/etc/init.d/dahdi-autoconf: line 179: 2: command not found
mv: cannot stat '/etc/dahdi/system.conf': No such file or directory                 [ ok ]


# sed '179!d' /etc/init.d/dahdi-autoconf
                                        $(( isdnport=isdnport+1 ))

If I run a BASH test script I can reproduce the same "problem" even though it seems to be safe as the isdnport value is properly incremented:

#!/bin/bash
isdnport=0
$(( isdnport=isdnport+1 ))
echo $isdnport

outputs:

./zzz.sh: line 3: 1: command not found
1

On the other hand,
mv /etc/dahdi/system.conf /etc/dahdi/system.conf.bck
yields the No such file or directory message, but it's apparently OK since it only happens on first run as /etc/dahdi/system.conf doesn't exist yet.
Comment 1 Jaco Kroon 2022-06-27 21:49:10 UTC
All of it is harmless, but fixed none-the less, just in case someone manages to get a command into your PATH for 2, 3 or 4 or something equally silly.
Comment 2 Larry the Git Cow gentoo-dev 2022-06-30 21:47:29 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=927a9ab6f7f379ad727928be6d7174cd62cce398

commit 927a9ab6f7f379ad727928be6d7174cd62cce398
Author:     Jaco Kroon <jaco@uls.co.za>
AuthorDate: 2022-06-15 13:06:51 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-06-30 21:46:42 +0000

    net-misc/dahdi-tools: revbump to fix bugs.
    
    No major changes.
    
    Biggest was to add T1 support into dahdi-autoconf.
    
    Closes: https://bugs.gentoo.org/841428
    Closes: https://bugs.gentoo.org/852779
    Closes: https://bugs.gentoo.org/852785
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Jaco Kroon <jaco@uls.co.za>
    Closes: https://github.com/gentoo/gentoo/pull/25852
    Signed-off-by: Sam James <sam@gentoo.org>

 net-misc/dahdi-tools/dahdi-tools-3.1.0-r3.ebuild   |  70 ++++++
 .../dahdi-tools/files/dahdi-autoconf.init-3.1.0-r3 | 271 +++++++++++++++++++++
 2 files changed, 341 insertions(+)