Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 839231 - x11-misc/lightdm: automated shellcheck found errors
Summary: x11-misc/lightdm: automated shellcheck found errors
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Marek Szuba
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-18 11:06 UTC by shellbugbot
Modified: 2022-09-27 12:22 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description shellbugbot 2022-04-18 11:06:07 UTC
Shellckeck found errors in one or more shellscripts provided by x11-misc/lightdm.

Kindly refer to the findings below and the shellcheck wiki for further details:

------------------------------------------------
script: /usr/portage/x11-misc/lightdm/files/Xsession:63

    for i in $(ls ${xsessionddir}) ; do
             ^^^^^^^^^^^^^^^^^^^^^
error: Iterating over ls output is fragile. Use globs. (https://github.com/koalaman/shellcheck/wiki/SC2045)

This is an automated bug report. Conservative settings were used to minimize false-positives but there's still a chance that the above list contains non-issues.
Running shellcheck again with default settings could detect other possible issues.

References:
[1] this script: https://github.com/heeplr/gentoo-shellbug
[2] shellcheck: https://www.shellcheck.net/
Comment 1 Larry the Git Cow gentoo-dev 2022-09-27 12:22:42 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=002eaccdcc97f77c60eef6588dbeb92fee7a2ada

commit 002eaccdcc97f77c60eef6588dbeb92fee7a2ada
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2022-09-27 11:31:03 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2022-09-27 12:22:30 +0000

    x11-misc/lightdm: some tweaks to start-up scripts
    
    Closes: https://github.com/gentoo/gentoo/pull/20597
    Closes: https://bugs.gentoo.org/839231
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 x11-misc/lightdm/files/Xsession-r1        |  75 +++++++++++++++
 x11-misc/lightdm/files/lightdm.service-r1 |  13 +++
 x11-misc/lightdm/lightdm-1.32.0-r1.ebuild | 155 ++++++++++++++++++++++++++++++
 3 files changed, 243 insertions(+)