Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 839225 - media-sound/mixxx: automated shellcheck found errors
Summary: media-sound/mixxx: automated shellcheck found errors
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Professional Audio Applications Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-18 11:06 UTC by shellbugbot
Modified: 2022-09-10 08:41 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description shellbugbot 2022-04-18 11:06:06 UTC
Shellckeck found errors in one or more shellscripts provided by media-sound/mixxx.

Kindly refer to the findings below and the shellcheck wiki for further details:

------------------------------------------------
script: /usr/portage/media-sound/mixxx/mixxx-9999.ebuild:10

if [[ "${PV}" == 9999 || ?.?.9999 ]] ; then
                         ^^^^^^^^
error: Globs are ignored in [[ ]] except right of =/!=. Use a loop. (https://github.com/koalaman/shellcheck/wiki/SC2203)

------------------------------------------------
script: /usr/portage/media-sound/mixxx/mixxx-9999.ebuild:10

if [[ "${PV}" == 9999 || ?.?.9999 ]] ; then
                          ^
error: Argument to implicit -n is always true due to literal strings. (https://github.com/koalaman/shellcheck/wiki/SC2157)

This is an automated bug report. Conservative settings were used to minimize false-positives but there's still a chance that the above list contains non-issues.
Running shellcheck again with default settings could detect other possible issues.

References:
[1] this script: https://github.com/heeplr/gentoo-shellbug
[2] shellcheck: https://www.shellcheck.net/
Comment 1 jospezial 2022-05-17 11:58:53 UTC
Please sync the mixxx-9999.ebuild with changes in the other ebuilds.
Comment 2 Larry the Git Cow gentoo-dev 2022-09-10 08:41:44 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e6c0d19b5ed4e6619bd2a4354ae6897390976117

commit e6c0d19b5ed4e6619bd2a4354ae6897390976117
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-09-10 08:01:36 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-09-10 08:40:19 +0000

    media-sound/mixxx: fix syntax, add media-libs/flac subslot dep
    
    media-libs/flac-1.4.0 breaks ABI.
    
    Closes: https://bugs.gentoo.org/839225
    Signed-off-by: Sam James <sam@gentoo.org>

 .../mixxx/{mixxx-2.3.3.ebuild => mixxx-2.3.3-r1.ebuild} |  8 ++++----
 media-sound/mixxx/mixxx-2.3.9999.ebuild                 |  6 +++---
 media-sound/mixxx/mixxx-9999.ebuild                     | 17 ++++++++---------
 3 files changed, 15 insertions(+), 16 deletions(-)