Bug 836229 – media-gfx/enblend-4.2.0_p20161007-r1 fails to compile: filespec.cc:471:31: error: GLOB_BRACE was not declared in this scope; did you mean GLOB_ERR? MUSL

• Status: CONFIRMED
• Product: Gentoo Linux

[Description Agostino Sarubbo 2022-03-26 21:08:29 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-gfx/enblend-4.2.0_p20161007-r1 fails to compile.
Discovered on: amd64 (internal ref: tinderbox_musl)

NOTE:
This machine uses MUSL libc

[Comment 1 Agostino Sarubbo 2022-03-26 21:08:31 UTC]

Created attachment 767929 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2022-03-26 21:08:32 UTC]

Created attachment 767930 [details]
1-CMakeError.log

1-CMakeError.log

[Comment 3 Agostino Sarubbo 2022-03-26 21:08:33 UTC]

Created attachment 767931 [details]
1-CMakeOutput.log

1-CMakeOutput.log

[Comment 4 Agostino Sarubbo 2022-03-26 21:08:33 UTC]

Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: src/CMakeFiles/enfuse.dir/filespec.cc.o 
/var/tmp/portage/media-gfx/enblend-4.2.0_p20161007-r1/work/enblend-4.2.0_p20161007/src/filespec.cc:471:31: error: 'GLOB_BRACE' was not declared in this scope; did you mean 'GLOB_ERR'?

[Comment 5 Willy 2024-03-05 22:37:06 UTC]

I filed this bug report for enblend https://bugs.launchpad.net/enblend/+bug/2056095, and the fix was commited on the following day.

To use it with the snapshot available at dev.gentoo.org/~soap (currently the URI in the ebuild), all that is needed is this patch:
```
diff -rup a/src/filespec.cc b/src/filespec.cc
--- a/src/filespec.cc   2016-09-24 04:28:47.000000000 -0500
+++ b/src/filespec.cc   2024-03-05 16:27:38.147063161 -0600
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2009-2016 Christoph L. Spiel
+ * Copyright (C) 2009-2017 Christoph L. Spiel
  *
  * This file is part of Enblend.
  *
@@ -468,7 +468,13 @@ public:
     FileNameList do_glob(const std::string& a_filespec,
                          const FilePositionTrace& trace)
     {
-       int flags = GLOB_ERR | GLOB_BRACE;
+       int flags = GLOB_ERR;
+#ifdef GLOB_BRACE
+       // not all libc implementations have GLOB_BRACE
+       // e.g. musl libc is not implenting GLOB_BRACE
+       // so check for it before using it
+       flags |= GLOB_BRACE;
+#endif
 #ifndef __sun__
        flags |= GLOB_TILDE;
 #endif
```