Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 833813 - x11-terms/aterm DEPEND: nonexistent package: x11-wm/afterstep
Summary: x11-terms/aterm DEPEND: nonexistent package: x11-wm/afterstep
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Ilia Mirkin
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-02-21 01:34 UTC by Jonas Stein
Modified: 2022-03-29 07:02 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonas Stein gentoo-dev 2022-02-21 01:34:57 UTC
pkgcheck scan --net
x11-terms/aterm
  DeprecatedEapi: version 1.0.1-r4: uses deprecated EAPI 6
  NonexistentDeps: version 1.0.1-r4: DEPEND: nonexistent package: x11-wm/afterstep
  NonexistentDeps: version 1.0.1-r4: RDEPEND: nonexistent package: x11-wm/afterstep
  UnusedInherits: version 1.0.1-r4: unused eclasses: eutils, flag-o-matic


Reproducible: Always
Comment 1 Ilia Mirkin 2022-02-21 01:46:33 UTC
One observation:

The ebuild has:

                $(use_enable background background-image) \
                --enable-background-image \

so ... can probably just drop that use flag entirely. Will dig into it. Would be slightly surprising if aterm really depended on afterstep WM for the background thing.
Comment 2 Ilia Mirkin 2022-02-23 07:02:34 UTC
I looked into it a bit. Just recording my findings for now:

1. --enable-background-image actually does nothing (contrary to what the docs might suggest). Perhaps it did something in older versions, but not anymore. Same goes for --enable-fading, --enable-menubar, and --enable-graphics.

2. There's some sort of conditional background logic which is indeed depend on the presence of some afterstep stuff - libAfterBase and libAfterImage, as well as libAfterStep. These are detected with the help of an "afterstep-config" utility.

So (a) we should drop the extra enables since they literally do nothing and (b) check whether media-libs/libafterimage can provide the necessary bits for the "background" functionality.
Comment 3 Larry the Git Cow gentoo-dev 2022-03-29 07:02:04 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3cb1463577df401d7de79f1983b9c5adbc3f07ee

commit 3cb1463577df401d7de79f1983b9c5adbc3f07ee
Author:     Ilia Mirkin <imirkin@alum.mit.edu>
AuthorDate: 2022-03-28 05:38:23 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2022-03-29 07:01:40 +0000

    x11-terms/aterm: make background use flag work, drop afterstep reference
    
    The afterstep wm was dropped long ago. Instead, we just need afterimage,
    which is still in the repository. Fix dependency on that, and drop a
    bunch of configure flags which no longer do anything.
    
    Closes: https://bugs.gentoo.org/833813
    Closes: https://github.com/gentoo/gentoo/pull/24786
    Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 profiles/base/package.use.mask        |  2 +-
 x11-terms/aterm/aterm-1.0.1-r5.ebuild | 84 +++++++++++++++++++++++++++++++++++
 2 files changed, 85 insertions(+), 1 deletion(-)