Full error: ../../../../qtwebengine-5.15.2_p20211216/src/3rdparty/chromium/third_party/blink/renderer/platform/peerconnection/rtc_scoped_refptr_cross_thread_copier.h:14:8: error: redefinition of ‘struct WTF::CrossThreadCopier<rtc::scoped_refptr<U> >’ 14 | struct CrossThreadCopier<rtc::scoped_refptr<T>> { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from gen/third_party/blink/renderer/modules/peerconnection/peerconnection_jumbo_2.cc:6: ./../../../../qtwebengine-5.15.2_p20211216/src/3rdparty/chromium/third_party/blink/renderer/modules/peerconnection/peer_connection_tracker.cc:55:8: note: previous definition of ‘struct WTF::CrossThreadCopier<rtc::scoped_refptr<U> >’ 55 | struct CrossThreadCopier<rtc::scoped_refptr<T>> { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from gen/third_party/blink/renderer/modules/peerconnection/peerconnection_jumbo_2.cc:30: ./../../../../qtwebengine-5.15.2_p20211216/src/3rdparty/chromium/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection_handler.cc:75:8: error: redefinition of ‘struct WTF::CrossThreadCopier<scoped_refptr<webrtc::DataChannelInterface> >’ 75 | struct CrossThreadCopier<scoped_refptr<DataChannelInterface>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from gen/third_party/blink/renderer/modules/peerconnection/peerconnection_jumbo_2.cc:9: ./../../../../qtwebengine-5.15.2_p20211216/src/3rdparty/chromium/third_party/blink/renderer/modules/peerconnection/rtc_data_channel.cc:56:8: note: previous definition of ‘struct WTF::CrossThreadCopier<scoped_refptr<webrtc::DataChannelInterface> >’ 56 | struct CrossThreadCopier<scoped_refptr<webrtc::DataChannelInterface>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Similar issue in previous version: #813957 My setting for jumbo: EXTRA_GN='use_jumbo_build=true jumbo_file_merge_limit=30' Reproducible: Always Steps to Reproduce: 1.set USE jumbo-build for webengine 2.set EXTRA_GN='use_jumbo_build=true jumbo_file_merge_limit=30' 3.compile qtwebengine Actual Results: Compilation fails, see description Expected Results: Compilation works? :) I did not keep build.log, I will try to add it later (compilation takes a few hours to fail)
Created attachment 761038 [details] Full build log
Created attachment 761039 [details] emerge info
Please disable ccache and try again.
Note that I don't think (from a skim) that it's similar other than being a jumbo build error. These things are sadly very dependent on the build order/combination order.
@Sam: I agree, that's not exactly the same issue but another jumbo issue. Patch from #813957 works fine but not with this build order/combination/new bump in my case.
As expected, without ccache, same issue: ../../../../qtwebengine-5.15.2_p20211216/src/3rdparty/chromium/third_party/blink/renderer/platform/peerconnection/rtc_scoped_refptr_cross_thread_copier.h:14:8: error: redefinition of ‘struct WTF::CrossThreadCopier<rtc::scoped_refptr<U> >’ 14 | struct CrossThreadCopier<rtc::scoped_refptr<T>> { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from gen/third_party/blink/renderer/modules/peerconnection/peerconnection_jumbo_2.cc:6: ./../../../../qtwebengine-5.15.2_p20211216/src/3rdparty/chromium/third_party/blink/renderer/modules/peerconnection/peer_connection_tracker.cc:55:8: note: previous definition of ‘struct WTF::CrossThreadCopier<rtc::scoped_refptr<U> >’ 55 | struct CrossThreadCopier<rtc::scoped_refptr<T>> { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from gen/third_party/blink/renderer/modules/peerconnection/peerconnection_jumbo_2.cc:30: ./../../../../qtwebengine-5.15.2_p20211216/src/3rdparty/chromium/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection_handler.cc:75:8: error: redefinition of ‘struct WTF::CrossThreadCopier<scoped_refptr<webrtc::DataChannelInterface> >’ 75 | struct CrossThreadCopier<scoped_refptr<DataChannelInterface>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from gen/third_party/blink/renderer/modules/peerconnection/peerconnection_jumbo_2.cc:9: ./../../../../qtwebengine-5.15.2_p20211216/src/3rdparty/chromium/third_party/blink/renderer/modules/peerconnection/rtc_data_channel.cc:56:8: note: previous definition of ‘struct WTF::CrossThreadCopier<scoped_refptr<webrtc::DataChannelInterface> >’ 56 | struct CrossThreadCopier<scoped_refptr<webrtc::DataChannelInterface>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Created attachment 761321 [details] build.log.bz2
(In reply to Sébastien P. from comment #0) > Similar issue in previous version: #813957 > My setting for jumbo: EXTRA_GN='use_jumbo_build=true > jumbo_file_merge_limit=30' Higher than usual 'jumbo_file_merge_limit' is what I ended up suspecting being the cause for bug 813957, though I forgot to mention it there. If that ends up being true, I'm not sure if we should keep patching these up. Upstream /might/ be interested on it though.
(In reply to Chiitoo from comment #8) > (In reply to Sébastien P. from comment #0) > > Similar issue in previous version: #813957 > > My setting for jumbo: EXTRA_GN='use_jumbo_build=true > > jumbo_file_merge_limit=30' > > Higher than usual 'jumbo_file_merge_limit' is what I ended up suspecting > being the cause for bug 813957, though I forgot to mention it there. It looks like 100 has the default: https://forums.gentoo.org/viewtopic-t-1074724.html Of course, I can try to reduce it. I tried to search a bit but did not any recommandation about that number. > If that ends up being true, I'm not sure if we should keep patching these > up. Upstream /might/ be interested on it though. @sultan has upstreamed part of the previous fix (https://bugs.gentoo.org/813957#c22). But I do not think it was related to jumbo (do it?). He also wrote down: > Should I write a patch? However, it is unlikely to get merged in Chromium. Are you talking about Qt upstream? I do not find any relevant bug about jumbo/redefition : https://bugreports.qt.io/browse/QTBUG-95955?jql=description ~ %22webengine%22 and text ~ %22redefinition%22 ORDER BY updated DESC Or any build documentation on their website. Does Qt really support jumbo? Maybe I am looking to the wrong place.
(In reply to Sébastien P. from comment #9) > (In reply to Chiitoo from comment #8) > > (In reply to Sébastien P. from comment #0) > > > Similar issue in previous version: #813957 > > > My setting for jumbo: EXTRA_GN='use_jumbo_build=true > > > jumbo_file_merge_limit=30' > > > > Higher than usual 'jumbo_file_merge_limit' is what I ended up suspecting > > being the cause for bug 813957, though I forgot to mention it there. > > It looks like 100 has the default: > https://forums.gentoo.org/viewtopic-t-1074724.html > Of course, I can try to reduce it. I tried to search a bit but did not any > recommandation about that number. 100 is (or was) the default for Chromium perhaps, but it's only 8 for Qt WebEngine (though I know Qt upstream tests or at least tested with some higher numbers as well in the past). > > If that ends up being true, I'm not sure if we should keep patching these > > up. Upstream /might/ be interested on it though. > > @sultan has upstreamed part of the previous fix > (https://bugs.gentoo.org/813957#c22). But I do not think it was related to > jumbo (do it?). > He also wrote down: > > Should I write a patch? However, it is unlikely to get merged in Chromium. > > Are you talking about Qt upstream? > I do not find any relevant bug about jumbo/redefition : > https://bugreports.qt.io/browse/QTBUG-95955?jql=description ~ > %22webengine%22 and text ~ %22redefinition%22 ORDER BY updated DESC > Or any build documentation on their website. > Does Qt really support jumbo? Maybe I am looking to the wrong place. Yes, Qt. Google has not supported jumbo builds in Chromium for a good while now (hence the "it is unlikely to get merged in Chromium" probably), but Qt decided to keep supporting it for WebEngine builds. I don't know of any bugs either, but I know they do fix this kind of issues [1]. However, I'm not sure how high of a limit they'd be willing to go for. 1. https://codereview.qt-project.org/q/project:qt/qtwebengine-chromium+jumbo
> I don't know of any bugs either, but I know they do fix this kind of issues > [1]. However, I'm not sure how high of a limit they'd be willing to go for. > > 1. https://codereview.qt-project.org/q/project:qt/qtwebengine-chromium+jumbo Thanks for the link, I will try to have a look this weekend and will try to create an upstream bug. I found this link: https://github.com/qt/qtwebengine/blob/dev/configure.cmake#L245 8 looks to be the standard limit as you said. I tried with a limit=8 and qtwebengine compiled fine.
Upstream ticket created. Let's see theirs comments later.
*** Bug 839051 has been marked as a duplicate of this bug. ***
Ticket closed by upstream (https://bugreports.qt.io/browse/QTBUG-103314?focusedCommentId=660648&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-660648). It “should” be fixed on newer versions of qtwebengine. Not sure I will try with limit=30 again. 8 produces almost the same number of files to compile, the difference of compilation time does not worth it. I do not know if this bug should stay open: =dev-qt/qtwebengine-5.15.2_p20211216 is not on portage anymore.
Long time ago. Did not meet any issue with 8.
