Created attachment 747972 [details] emerge --info After the update to 'media-sound/pulseaudio-15.0-r1', PulseEffects stopped working. Program starts but it doesn't load it's sound devices or produce any effect in the sound.
Created attachment 747975 [details] pulseeffects log
Created attachment 748065 [details] pulseaudio stack trace I noticed a silent crash on pulseaudio that happens when starting playback. File name was 'core-null-sink-s6-t1635868382', that likely points to what produced it.
Installed pulseeffects-4.8.5-r1 now and cannot reproduce this issue. If you can reproduce this pulseaudio crash at will, could you please stop pulseaudio, start it like this: 'pulseaudio -vvvvv > /tmp/pulse-verbose.log' then reproduce the issue and attach the log here?
Created attachment 748095 [details] pulse verbose log managed to reproduce the crash by opening pulseeffects while in the middle of playback
Created attachment 748113 [details] pulseeffects stack trace crashing this way produces an additional core dump from pulseeffects itself
Thanks, looks like last crash is due to module-null-sink was caught during format change. The code which crashed looks like there for ages, so maybe something else is changed. I still cannot reproduce the crash, could you please share pa-info output? Maybe you do set some configuration parameter that I do not have here.
Created attachment 748119 [details] debug patch for module-null-sink crash when sample rate is changed Could you please try reproducing issue with this debugging patch applied? This double-checks that internal frame alignment is still correct when module-null-sink is ready to render audio samples.
Please also test this proposed change https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/658 which should fix misaligned value so assertion is no longer triggered.
I reproduced this crash 1. in daemon.conf set avoid-resampling=true 2. start playing audio with format different from default one, e.g. if default is s16le use float mpv --audio-format=float --audio-samplerate=96000 * 3. start pulseeffects here the crash happens instantly, with same assertion. This proposed change https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/658 fixes the issue.
I can confirm that the `avoid-resampling = true` setting caused the issue. Removed that setting from my config file (on unpatched pulse) and everything works fine. Also tried the patch posted on gitlab patch and it works, PulseEffects is now working fine with avoid-resampling enabled.
https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/658 is now merged upstream.
Upstream have assigned to the 16.0 milestone so I guess this patch should be backported to pulseaudio-15 in Gentoo.
(In reply to Marek Szuba from comment #12) > Upstream have assigned to the 16.0 milestone so I guess this patch should be > backported to pulseaudio-15 in Gentoo. Will wait to see what Igor says first as he's an upstream developer first, but yeah, sounds reasonable.
(In reply to Sam James from comment #13) > (In reply to Marek Szuba from comment #12) > > Upstream have assigned to the 16.0 milestone so I guess this patch should be > > backported to pulseaudio-15 in Gentoo. > > Will wait to see what Igor says first as he's an upstream developer first, > but yeah, sounds reasonable. I think this change is worth backporting, not sure if I understand all concerns around that though.
(In reply to Igor V. Kovalenko from comment #14) > (In reply to Sam James from comment #13) > > (In reply to Marek Szuba from comment #12) > > > Upstream have assigned to the 16.0 milestone so I guess this patch should be > > > backported to pulseaudio-15 in Gentoo. > > > > Will wait to see what Igor says first as he's an upstream developer first, > > but yeah, sounds reasonable. > I think this change is worth backporting, not sure if I understand all > concerns around that though. I think it's mostly "if it's a safe enough change, do it". And it's a bug fix, not a new feature.
Yes, this change is quite simple and safe, please apply!
Obsolete given we have 16.0 now.
