Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 818667 - New release of media-sound/mpd-0.23.0
Summary: New release of media-sound/mpd-0.23.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mikle Kolyada (RETIRED)
URL: https://musicpd.org/news/2021/10/mpd-...
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2021-10-17 11:43 UTC by Neil
Modified: 2022-01-10 14:23 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild for mpd-0.23 (mpd-0.23.ebuild,8.40 KB, text/plain)
2021-10-17 11:44 UTC, Neil
Details
mpd-0.23.2.ebuild (mpd-0.23.2.ebuild,8.40 KB, text/plain)
2021-10-24 08:52 UTC, Neil
Details
Fixed tidal build error (mpd-0.23.4.ebuild,8.81 KB, text/plain)
2021-11-30 19:06 UTC, Kenton Groombridge
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Neil 2021-10-17 11:43:29 UTC
New release of mpd.

Brings native support for snapcast so perhaps a new USE_FLAG is required to pull that in if the user wants to include it.

I've had a stab at adapting the ebuild to include a snapcast flag and it appears to build (I already have snapcast installed on my system). I added a default USE flag fmt to pull in dev-libs/libfmt which I didn't have installed and the meson configure stage complained about fmt not being found.

Currently no example of how to configure snapcast is provided in the doc/mpdconf.example

Reproducible: Always
Comment 1 Neil 2021-10-17 11:44:06 UTC
Created attachment 745440 [details]
Ebuild for mpd-0.23
Comment 2 Neil 2021-10-20 14:34:29 UTC
A bug on the snapcast front I reported has been fixed along with a few others and 0.23.1 is available already.

https://raw.githubusercontent.com/MusicPlayerDaemon/MPD/v0.23.1/NEWS
Comment 3 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2021-10-21 19:45:49 UTC
I have no plans of adding in near 2-3 weeks it exactly because of the "we do not test our code and then release" lets wait for all the bugs
Comment 4 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2021-10-21 19:46:32 UTC
also could you please provide a diff? It is easier to see what got changed
Comment 5 Neil 2021-10-24 08:51:32 UTC
Sure perfectly understandable, it seems more minor bugs are being ironed out as 0.23.2 has now been released. I've attached my ebuild for 0.23.2, the diff is...


kimura /usr/local/portage/media-sound/mpd # diff mpd-0.23.2.ebuild /usr/portage/media-sound/mpd/mpd-0.22.9-r1.ebuild 
10c10
< SRC_URI="https://musicpd.org/download/${PN}/${PV%.*}/${P}.tar.xz"
---
> SRC_URI="https://www.musicpd.org/download/${PN}/${PV%.*}/${P}.tar.xz"
14c14
< KEYWORDS="~alpha ~amd64 ~arm ~ppc ~ppc64 ~riscv ~x86"
---
> KEYWORDS="~alpha ~amd64 ~arm ~ppc ~ppc64 ~x86"
16c16
< 	+eventfd expat faad +ffmpeg +fifo flac fluidsynth +fmt gme +icu +id3tag +inotify
---
> 	+eventfd expat faad +ffmpeg +fifo flac fluidsynth gme +icu +id3tag +inotify
19,20c19,20
< 	recorder samba selinux sid signalfd snapcast sndfile sndio soundcloud sqlite
< 	systemd	test tidal twolame udisks vorbis wavpack webdav wildmidi upnp
---
> 	recorder samba selinux sid signalfd sndfile sndio soundcloud sqlite systemd
> 	test tidal twolame udisks vorbis wavpack webdav wildmidi upnp
64d63
< 	fmt? ( dev-libs/libfmt )
91d89
< 	snapcast? ( media-sound/snapcast )
kimura /usr/local/portage/media-sound/mpd #
Comment 6 Neil 2021-10-24 08:52:45 UTC
Created attachment 746391 [details]
mpd-0.23.2.ebuild
Comment 7 Kenton Groombridge gentoo-dev 2021-11-09 20:17:30 UTC
mpd 0.23.3 is out. Also looking forward to a version bump for this, as the current version of mpd cannot be compiled with clang and -stdlib=libc++
Comment 9 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-11-14 19:56:59 UTC
(it's unkeyworded)
Comment 10 Kenton Groombridge gentoo-dev 2021-11-30 19:05:37 UTC
Thanks for the bump Sam! Unfortunately, it seems that 0.23.4 fails to build as-is with this error:

meson.build:1:0: ERROR: Unknown options: "tidal"

Looks like the tidal plugin was deprecated recently: https://github.com/MusicPlayerDaemon/MPD/commit/97c43954e8df3f772899cda951ad5a7dd4a24f25

I've modified the ebuild by simply removing this option (and USE flag) and it builds fine.
Comment 11 Kenton Groombridge gentoo-dev 2021-11-30 19:06:13 UTC
Created attachment 757102 [details]
Fixed tidal build error
Comment 12 Larry the Git Cow gentoo-dev 2021-12-01 16:53:49 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=15968bac591fa32cd6861206ac3b88dbed79ea2b

commit 15968bac591fa32cd6861206ac3b88dbed79ea2b
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-12-01 16:53:22 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-12-01 16:53:41 +0000

    media-sound/mpd: drop removed tidal support in 0.23.4
    
    Bug: https://bugs.gentoo.org/818667
    Thanks-to: 0xC0ncord
    Signed-off-by: Sam James <sam@gentoo.org>

 media-sound/mpd/mpd-0.23.4.ebuild | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
Comment 13 Neil 2021-12-06 11:46:34 UTC
0.23.5 has been released which addresses some bugs.