Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 767154 - app-backup/dar-2.6.13 version bump
Summary: app-backup/dar-2.6.13 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-25 14:06 UTC by jwdev
Modified: 2021-02-18 10:30 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
dar-2.6.13.ebuild (dar-2.6.13.ebuild,2.45 KB, text/plain)
2021-01-25 14:06 UTC, jwdev
Details
patch (patch,1.48 KB, patch)
2021-01-25 14:53 UTC, jwdev
Details | Diff
dar-2.6.13-r1.ebuild (dar-2.6.13-r1.ebuild,2.42 KB, text/plain)
2021-02-02 19:47 UTC, jwdev
Details
patch (patch,1.51 KB, patch)
2021-02-02 19:51 UTC, jwdev
Details | Diff
dar-2.6.13-r1.ebuild (dar-2.6.13-r1.ebuild,2.42 KB, text/plain)
2021-02-02 19:57 UTC, jwdev
Details
patch (patch,1.40 KB, patch)
2021-02-02 19:58 UTC, jwdev
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jwdev 2021-01-25 14:06:20 UTC
Created attachment 684633 [details]
dar-2.6.13.ebuild

The latest available version in the portage tree is 2.6.10. I modified the ebuild for version 2.6.13.

I tested different USE-flag combinations and added a new flag "librsync" that controls whether dar will be built with net-libs/librsync. That should fix bug #739698. I also tested that new flag.

I did not test static builds. Also I added a line to REQUIRED_USE to prevent static building if librsync is enabled. The reason behind this is that the librsync ebuild does not support static builds.
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2021-01-25 14:14:58 UTC
Can you please attach a unified diff file (diff -u old new > patch) showing the changes you did to the ebuild?
Comment 2 jwdev 2021-01-25 14:53:53 UTC
Created attachment 684636 [details, diff]
patch

patch from dar-2.6.10.ebuild to dar-2.6.13.ebuild
Comment 3 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2021-02-01 15:57:20 UTC
We already have a "rsync" USE flag in another package (net-misc/scponly). Would you mind renaming "librsync" USE flag to "rsync" please?
Comment 4 jwdev 2021-02-02 19:47:10 UTC
Created attachment 685572 [details]
dar-2.6.13-r1.ebuild

renamed use-flag "librsync" to "rsync"
Comment 5 jwdev 2021-02-02 19:51:11 UTC
Created attachment 685575 [details, diff]
patch

patch from dar-2.6.10.ebuild to dar-2.6.13-r1.ebuild
Comment 6 jwdev 2021-02-02 19:57:28 UTC
Created attachment 685578 [details]
dar-2.6.13-r1.ebuild

corrected mistake: USE-flags and RDEPEND statements were ordered wrongly.
Comment 7 jwdev 2021-02-02 19:58:20 UTC
Created attachment 685581 [details, diff]
patch

corrected patch against dar-2.6.10 from the tree.
Comment 8 jwdev 2021-02-02 20:05:20 UTC
Additionally I'd like to mention that I dropped the ~amd64-linux keyword as there were missing dependencies on that prefix architecture so repoman complained about it.
Comment 9 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-02-18 08:30:26 UTC
Sorry, missed this somehow(?)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ef2829d1ac400892265dab27dd486e5a8710c740

Looks like we may still need to do the librsync thing though?
Comment 10 jwdev 2021-02-18 10:30:32 UTC
(In reply to Sam James from comment #9)
> Sorry, missed this somehow(?)
> 
> https://gitweb.gentoo.org/repo/gentoo.git/commit/
> ?id=ef2829d1ac400892265dab27dd486e5a8710c740
> 
> Looks like we may still need to do the librsync thing though?

I already implemented it weeks ago, just have a look at the attachment "dar-2.6.13-r1.ebuild" above.