Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 763579 - net-vpn/openconnect-8.10-r1 typos, can't supply server and password via configuration file
Summary: net-vpn/openconnect-8.10-r1 typos, can't supply server and password via confi...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal with 2 votes (vote)
Assignee: William Hubbs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-04 21:24 UTC by Gabriel Marcano
Modified: 2021-10-02 17:20 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriel Marcano 2021-01-04 21:24:32 UTC
The newest release of openconnect warns that:
        ewarn "server_${VPN}, vpnopts${VPN} and password_${VPN} are deprecated"
        ewarn"Please move them to the appropriate settings in ${VPNCONF}"
        ewarn "They will be ignored in the future."

The server option and the password option cannot be specified in the configuration file, thus if these are removed in the future, it's unclear how one would provide these to the service.

Also, those lines in the init.d file look wrong. There's a missing space after an ewarn, and a missing _ in vpnopts${VPN}. These warnings also fire even if all of these options are blank.

Are the missing "" in the VPNCONF variable near the top of the init file?

It used to be the case that the default configuration sample provided a --script=/etc/openconnect/openconnect.sh option, but there's no mention of this anymore. Is this an oversight or is this intended?

Reproducible: Always

Steps to Reproduce:
1. Install openconnect-8.10-r1
2. Create a basic configuration file (empty might work?)
3. Try to launch via rc-service
Actual Results:  
openconnect.vpn   | * This will become a fatal error in a future release.                                                                                                                   
openconnect.vpn   | * server_vpn, vpnoptsvpn and password_vpn are deprecated                                                                                                             
openconnect.vpn   |/etc/init.d/openconnect.vpn: line 43: ewarnPlease move them to the appropriate settings in /etc/openconnect/vpn.conf: No such file or directory                        
openconnect.ucsd   | * They will be ignored in the future

Expected Results:  
No warnings

$ emerge --info
/home/gabriel/.local/lib/python3.7/site-packages/requests/__init__.py:91: RequestsDependencyWarning: urllib3 (1.26.2) or chardet (4.0.0) doesn't match a supported version!
  RequestsDependencyWarning)
Portage 3.0.12 (python 3.7.9-final-0, default/linux/amd64/17.1/desktop/plasma, gcc-10.2.0, glibc-2.32-r6, 5.10.4-gentoo x86_64)
=================================================================
System uname: Linux-5.10.4-gentoo-x86_64-Intel-R-_Core-TM-_i7-3770K_CPU_@_3.50GHz-with-gentoo-2.7
KiB Mem:    16350332 total,    564184 free
KiB Swap:   16776192 total,  16775168 free
Timestamp of repository gentoo: Mon, 04 Jan 2021 20:05:13 +0000
Head commit of repository gentoo: 4d34d61973b507aa45e5e365c65bcd9b5ce0c765

sh bash 5.1_p4
ld GNU ld (Gentoo 2.35.1 p2) 2.35.1
distcc 3.3.3 x86_64-pc-linux-gnu [disabled]
ccache version 4.1 [disabled]
app-shells/bash:          5.1_p4::gentoo
dev-java/java-config:     2.3.1::gentoo
dev-lang/perl:            5.32.0-r1::gentoo
dev-lang/python:          2.7.18-r5::gentoo, 3.7.9-r1::gentoo, 3.8.7::gentoo, 3.9.1::gentoo
dev-util/ccache:          4.1::gentoo
dev-util/cmake:           3.19.2::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.7-r1::gentoo
sys-apps/openrc:          0.42.1::gentoo
sys-apps/sandbox:         2.20::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r5::gentoo
sys-devel/automake:       1.16.3-r1::gentoo
sys-devel/binutils:       2.35.1-r1::gentoo
sys-devel/gcc:            10.2.0-r5::gentoo
sys-devel/gcc-config:     2.3.2-r1::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.3::gentoo
sys-kernel/linux-headers: 5.10::gentoo (virtual/os-headers)
sys-libs/glibc:           2.32-r6::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: git
    sync-uri: git://github.com/gentoo-mirror/gentoo
    priority: -1000
    sync-git-verify-commit-signature: true

Local_Overlay
    location: /var/db/repos/local
    masters: gentoo
    eclass-overrides: gentoo Local_Overlay

crossdev
    location: /var/db/repos/crossdev
    masters: gentoo
    eclass-overrides: gentoo crossdev

brother-overlay
    location: /var/lib/layman/brother-overlay
    masters: gentoo
    priority: 50

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=ivybridge -pipe -fomit-frame-pointer -O3 -flto"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /opt/brother/scanner/brscan4/brsanenetdevice4.cfg /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=ivybridge -pipe -fomit-frame-pointer -O3 -flto"
DISTDIR="/var/cache/distfiles"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-march=ivybridge -pipe -fomit-frame-pointer -O3 -flto"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs clean-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms split-log strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-march=ivybridge -pipe -fomit-frame-pointer -O3 -flto"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en es"
MAKEOPTS="-j9"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/tmp"
USE="=-ppp X a52 aac acl acpi activities alsa amd64 avx bash-completion berkdb bluetooth branding bzip2 cairo cdda cdr cli crypt cups dbus declarative dri dts dvd dvdr elogind emboss encode exif flac fortran gdbm gif gpm gtk gui iconv icu ipv6 jpeg kde kipi kwallet lcms libglvnd libnotify libtirpc lm-sensors lto mad mmx mng mp3 mp4 mpeg mtp multilib ncurses nls nptl nvidia ogg opengl openmp pam pango pcre pdf phonon plasma png policykit ppds pulseaudio qml qt qt5 readline sdl seccomp semantic-desktop spell split-usr sse sse2 sse3 sse4 ssl startup-notification svg tcpd tiff truetype udev udisks unicode upower usb vdpau vorbis widgets wxwidgets x264 xattr xcb xml xv xvid zeroconf zlib" ABI_X86="64" ADA_TARGET="gnat_2018" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64 emu" INPUT_DEVICES="evdev roccat_tyon" KERNEL="linux" L10N="en es" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2 php7-3 php7-4" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_8" PYTHON_TARGETS="python2_7 python3_8 python3_7 python3_8" RUBY_TARGETS="ruby27 ruby28" SANE_BACKENDS="test" USERLAND="GNU" VIDEO_CARDS="nvidia" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Larry the Git Cow gentoo-dev 2021-10-02 06:01:58 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e7ea3fbeadbd0524ea7d7498a8eb563b0b780495

commit e7ea3fbeadbd0524ea7d7498a8eb563b0b780495
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2021-10-02 05:54:38 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2021-10-02 06:00:09 +0000

    net-vpn/openconnect: revise init script
    
    Remove warnings about removal of variables.
    Restore sample conf.d file.
    Allow for missing config file.
    Use eval to allow quoted whitespace in vpnopts.
    
    Bug: https://bugs.gentoo.org/733614
    Closes: https://bugs.gentoo.org/763579
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 net-vpn/openconnect/files/openconnect.conf.in      |   2 +-
 net-vpn/openconnect/files/openconnect.initd        | 109 +++++++++++++++++++++
 ...t-8.10-r2.ebuild => openconnect-8.10-r3.ebuild} |   5 +-
 net-vpn/openconnect/openconnect-9999.ebuild        |   5 +-
 4 files changed, 118 insertions(+), 3 deletions(-)
Comment 2 Larry the Git Cow gentoo-dev 2021-10-02 17:20:02 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d08fe11b2b09f874ea8a2fbd296f69a4ce073702

commit d08fe11b2b09f874ea8a2fbd296f69a4ce073702
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2021-10-02 17:07:50 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2021-10-02 17:19:57 +0000

    net-vpn/openconnect: rewrite initscript
    
    Support for the server_${VPN}, password_${VPN}, and vpnopts_${VPN}
    variables is dropped.
    
    Per-VPN variables are now defined in /etc/conf.d/openconnect.${vpn}.
    
    Instead of defining server and vpnopts, the user should set command_args
    which will be passed to openconnect via the default_start function.
    
    Support for 'password' and 'password_file' variables is added. If neither
    is specified, the password will be prompted for interactively.
    
    Support for up/down hooks is dropped. The functionality can be replaced
    with vpnc-script hooks.
    
    Bug: https://bugs.gentoo.org/733614
    Bug: https://bugs.gentoo.org/763579
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 net-vpn/openconnect/files/README.OpenRC            |  25 +----
 net-vpn/openconnect/files/openconnect.confd        |   6 ++
 net-vpn/openconnect/files/openconnect.initd        | 107 +++------------------
 ...t-8.10-r3.ebuild => openconnect-8.10-r4.ebuild} |   2 +-
 net-vpn/openconnect/openconnect-9999.ebuild        |   2 +-
 5 files changed, 25 insertions(+), 117 deletions(-)