Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 760678 - sci-mathematics/flint-2.7.0 has an automagic dependency on cblas that is taken care in the ebuild
Summary: sci-mathematics/flint-2.7.0 has an automagic dependency on cblas that is take...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Patrick Lauer
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-12-19 00:33 UTC by François Bissey
Modified: 2021-03-15 18:01 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description François Bissey 2020-12-19 00:33:55 UTC
Michael committed a flint 2.7.0 ebuild before my PR was ready (because of real life).

The new ebuild doesn't declare any dependency on cblas which is automagically detected by the configuring system (cmake). 

Moreover cblas implementation are detected in the order: openblas, generic cblas, blis. Which means that openblas will be linked to directly if found, instead of using ldso selection.

Reproducible: Always
Comment 1 François Bissey 2020-12-19 00:46:44 UTC
Basic diff between current ebuild and mine:
@@ -29,16 +26,24 @@ BDEPEND="doc? (
        ${PYTHON_DEPS}"
 DEPEND="dev-libs/gmp:=
        dev-libs/mpfr:=
-       ntl? ( dev-libs/ntl:= )"
+       ntl? ( dev-libs/ntl:= )
+       virtual/cblas"
 RDEPEND="${DEPEND}"
 
-PATCHES=( "${FILESDIR}/${PN}-2.6.0-multilib-strict.patch" )
+PATCHES=(
+       "${FILESDIR}"/${PN}-2.6.0-multilib-strict.patch
+)
+
+# ninja doesn't like "-lcblas" so using make.
+CMAKE_MAKEFILE_GENERATOR="emake"
 
 src_configure() {
        local mycmakeargs=(
                -DWITH_NTL="$(usex ntl)"
                -DBUILD_TESTING="$(usex test)"
                -DBUILD_DOCS="$(usex doc)"
+               -DCBLAS_INCLUDE_DIRS="${EPREFIX}/usr/include"
+               -DCBLAS_LIBRARIES="-lcblas"
        )
 
        cmake_src_configure
Comment 2 Larry the Git Cow gentoo-dev 2021-01-23 15:33:27 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=309ad0dd85afb5347a059b761a0256d638346053

commit 309ad0dd85afb5347a059b761a0256d638346053
Author:     François Bissey <frp.bissey@gmail.com>
AuthorDate: 2021-01-21 20:10:40 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2021-01-23 15:30:52 +0000

    sci-mathematics/flint: upstream bump and fix bugs
    
    Package-Manager: Portage-3.0.13, Repoman-3.0.2
    Bug: https://bugs.gentoo.org/761736
    Bug: https://bugs.gentoo.org/760678
    Closes: https://github.com/gentoo/gentoo/pull/19152
    Signed-off-by: François René Pierre Bissey <frp.bissey@gmail.com>
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 sci-mathematics/flint/flint-2.7.1.ebuild | 69 ++++++++++++++++++++++++++++++++
 1 file changed, 69 insertions(+)