Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 759985 - dev-lang/spidermonkey:78: Add patch to make js::SharedArrayRawBufferRefs public
Summary: dev-lang/spidermonkey:78: Add patch to make js::SharedArrayRawBufferRefs public
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL: https://bugzilla.mozilla.org/show_bug...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-14 10:19 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2020-12-14 18:38 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to be added to spidermonkey patchset (SharedArrayRawBufferRefs_public.patch,393 bytes, patch)
2020-12-14 10:23 UTC, Arfrever Frehtes Taifersar Arahesis
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2020-12-14 10:19:48 UTC
dev-lang/spidermonkey:78 needs patch to make class js::SharedArrayRawBufferRefs public:
https://bugzilla.mozilla.org/show_bug.cgi?id=1644600


Before fix:
> $ nm -CD /usr/lib64/libmozjs-78.so | grep SharedArrayRawBufferRefs
> $ 

After fix:
> $ nm -CD /usr/lib64/libmozjs-78.so | grep SharedArrayRawBufferRefs
> 00000000003ebb40 T js::SharedArrayRawBufferRefs::acquireAll(JSContext*, js::SharedArrayRawBufferRefs const&)
> 00000000003e8880 T js::SharedArrayRawBufferRefs::releaseAll()
> 00000000003e8750 T js::SharedArrayRawBufferRefs::takeOwnership(js::SharedArrayRawBufferRefs&&)
> 00000000003eba80 T js::SharedArrayRawBufferRefs::acquire(JSContext*, js::SharedArrayRawBuffer*)
> 00000000003e88f0 T js::SharedArrayRawBufferRefs::~SharedArrayRawBufferRefs()
> 00000000003e88f0 T js::SharedArrayRawBufferRefs::~SharedArrayRawBufferRefs()
> 00000000003e8830 T js::SharedArrayRawBufferRefs::operator=(js::SharedArrayRawBufferRefs&&)
> $ 


Example failure seen in recent version of games-strategy/0ad (which uses system dev-lang/spidermonkey:78):
> /usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../x86_64-pc-linux-gnu/bin/ld.bfd: ../../../binaries/system/libscriptinterface.a(ScriptInterface.o): in function `std::_Sp_counted_ptr<JSStructuredCloneData*, (__gnu_cxx::_Lock_policy)2>::_M_dispose()':
> ScriptInterface.cpp:(.text._ZNSt15_Sp_counted_ptrIP21JSStructuredCloneDataLN9__gnu_cxx12_Lock_policyE2EE10_M_disposeEv[_ZNSt15_Sp_counted_ptrIP21JSStructuredCloneDataLN9__gnu_cxx12_Lock_policyE2EE10_M_disposeEv]+0x2e): undefined reference to `js::SharedArrayRawBufferRefs::~SharedArrayRawBufferRefs()'
> /usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../x86_64-pc-linux-gnu/bin/ld.bfd: ../../../binaries/system/libscriptinterface.a(ScriptInterface.o): in function `ScriptInterface::WriteStructuredClone(JS::Handle<JS::Value>) const [clone .cold]':
> ScriptInterface.cpp:(.text.unlikely+0x721): undefined reference to `js::SharedArrayRawBufferRefs::~SharedArrayRawBufferRefs()'
> collect2: error: ld returned 1 exit status
Comment 1 Arfrever Frehtes Taifersar Arahesis 2020-12-14 10:23:01 UTC
Created attachment 678274 [details, diff]
Patch to be added to spidermonkey patchset
Comment 2 Larry the Git Cow gentoo-dev 2020-12-14 18:38:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9fd045c263adc86f99aebd7ec273a691f0c8364b

commit 9fd045c263adc86f99aebd7ec273a691f0c8364b
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2020-12-14 18:34:10 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2020-12-14 18:38:22 +0000

    dev-lang/spidermonkey: bump to v78.6.0
    
    Closes: https://bugs.gentoo.org/759985
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 dev-lang/spidermonkey/Manifest                   |   2 +
 dev-lang/spidermonkey/metadata.xml               |   1 +
 dev-lang/spidermonkey/spidermonkey-78.6.0.ebuild | 418 +++++++++++++++++++++++
 profiles/base/package.use.force                  |   1 +
 4 files changed, 422 insertions(+)