Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 749756 - Duplicate use flags shown on packages.gentoo.org
Summary: Duplicate use flags shown on packages.gentoo.org
Status: RESOLVED FIXED
Alias: None
Product: Websites
Classification: Unclassified
Component: Packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Packages Website
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-17 13:47 UTC by gentoo@imrebuild.com
Modified: 2022-11-16 00:58 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description gentoo@imrebuild.com 2020-10-17 13:47:52 UTC
https://packages.gentoo.org/packages/x11-terms/st and https://packages.gentoo.org/packages/sys-kernel/linux-firmware both have two savedconfig on the "USE flags" section.

This is because they have both savedconfig eclass and a "savedconfig" in IUSE. Does portage fail to dedupe them? It works fine on local system.

Also, I found that "there is no need to specify USE flags used only within inherited eclasses within the ebuild's IUSE." from https://devmanual.gentoo.org/ebuild-writing/variables/index.html#iuse. Maybe we can also add a QA test for this?

Reproducible: Always
Comment 1 John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2022-11-16 00:58:49 UTC
*Maybe* fixed by:

commit 4ffea19d6578ba1b9dbded0fc3388e863f8d0012
Author: Max Magorsch <arzano@gentoo.org>
Date:   Mon May 18 02:52:01 2020 +0200

    Filter duplicate useflags by name not by id

    Signed-off-by: Max Magorsch <arzano@gentoo.org>

diff --git a/pkg/app/handler/packages/utils.go b/pkg/app/handler/packages/utils.go
index 3ea0cd1..13958c2 100644
--- a/pkg/app/handler/packages/utils.go
+++ b/pkg/app/handler/packages/utils.go
@@ -389,7 +389,7 @@ func sortVersionsDesc(versions []*models.Version) {
 // given userflag. Otherwise false will be returned.
 func containsUseflag(useflag models.Useflag, useflags []models.Useflag) bool {
        for _, flag := range useflags {
-               if useflag.Id == flag.Id {
+               if useflag.Name == flag.Name {
                        return true
                }
        }

Regardless, seems to be fixed now.