Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 740030 - games-action/supertuxkart-1.2 : * patch -p1 failed with .../files/supertuxkart-1.2-irrlicht-system-libs.patch
Summary: games-action/supertuxkart-1.2 : * patch -p1 failed with .../files/supertuxka...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-02 07:23 UTC by Toralf Förster
Modified: 2020-09-02 15:31 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,16.92 KB, text/plain)
2020-09-02 07:23 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,266.04 KB, text/plain)
2020-09-02 07:23 UTC, Toralf Förster
Details
environment (environment,99.87 KB, text/plain)
2020-09-02 07:23 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,28.05 KB, application/x-bzip)
2020-09-02 07:23 UTC, Toralf Förster
Details
games-action:supertuxkart-1.2:20200902-024953.log (games-action:supertuxkart-1.2:20200902-024953.log,3.22 KB, text/plain)
2020-09-02 07:23 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,24.34 KB, application/x-bzip)
2020-09-02 07:23 UTC, Toralf Förster
Details
supertuxkart-1.2-irrlicht-system-libs.patch (supertuxkart-1.2-irrlicht-system-libs.patch,1.89 KB, patch)
2020-09-02 08:44 UTC, Lars Wendler (Polynomial-C) (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2020-09-02 07:23:07 UTC
 [ !! ]
 * ERROR: games-action/supertuxkart-1.2::gentoo failed (prepare phase):
 *   patch -p1  failed with /var/tmp/portage/games-action/supertuxkart-1.2/files/supertuxkart-1.2-irrlicht-system-libs.patch
 * 
 * Call stack:
 *               ebuild.sh, line  125:  Called src_prepare

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_desktop-libressl-20200826-071836

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-7.3.1
 [2] x86_64-pc-linux-gnu-10.2.0 *
clang version 10.0.1 
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/10/bin
/usr/lib/llvm/10
10.0.1
Available Python interpreters, in order of preference:
  [1]   python3.7
  [2]   python3.9 (fallback)
  [3]   python3.8 (fallback)
  [4]   python3.6 (fallback)
  [5]   python2.7 (fallback)
  [6]   pypy3 (fallback)
Available Ruby profiles:
  [1]   ruby25 (with Rubygems) *
Available Rust versions:
  [1]   rust-bin-1.46.0
  [2]   rust-1.46.0 *
The following VMs are available for generation-2:
*)	IcedTea JDK 3.16.0 [icedtea-bin-8]
Available Java Virtual Machines:
  [1]   icedtea-bin-8  system-vm

The Glorious Glasgow Haskell Compilation System, version 8.8.4

  timestamp(s) of HEAD at this tinderbox image:
/var/db/repos/gentoo	Wed Sep  2 01:39:43 AM UTC 2020
/var/db/repos/libressl	Tue Sep  1 07:07:28 PM UTC 2020

emerge -qpvO games-action/supertuxkart
[ebuild  N    ] games-action/supertuxkart-1.2  USE="libressl -debug -nettle -recorder -sqlite -wiimote"
Comment 1 Toralf Förster gentoo-dev 2020-09-02 07:23:09 UTC
Created attachment 657866 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2020-09-02 07:23:12 UTC
Created attachment 657868 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2020-09-02 07:23:14 UTC
Created attachment 657870 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2020-09-02 07:23:16 UTC
Created attachment 657872 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2020-09-02 07:23:17 UTC
Created attachment 657874 [details]
games-action:supertuxkart-1.2:20200902-024953.log
Comment 6 Toralf Förster gentoo-dev 2020-09-02 07:23:18 UTC
Created attachment 657876 [details]
temp.tbz2
Comment 7 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2020-09-02 08:42:58 UTC
Seems like this patch has never been tested with the ebuild.

It's caused by the DOS line endings some of the source files the patch touches have.
Comment 8 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2020-09-02 08:44:16 UTC
Created attachment 657914 [details, diff]
supertuxkart-1.2-irrlicht-system-libs.patch

Patch with DOS line endings where necessary.
Comment 9 Larry the Git Cow gentoo-dev 2020-09-02 13:01:11 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4a338c733fff32fc0f42fe5ce3a94613cb87522d

commit 4a338c733fff32fc0f42fe5ce3a94613cb87522d
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2020-09-02 13:00:36 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2020-09-02 13:00:36 +0000

    games-action/supertuxkart: fix patch line-endings
    
    Unfortunately, I tested this *pre-commit* at which point
    git used its autocrlf to adapt the line-endings.
    
    Closes: https://bugs.gentoo.org/740030
    Package-Manager: Portage-3.0.5, Repoman-3.0.1
    Signed-off-by: Sam James <sam@gentoo.org>

 .../supertuxkart-1.2-irrlicht-system-libs.patch    | 50 +++++++++++-----------
 1 file changed, 24 insertions(+), 26 deletions(-)
Comment 10 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-09-02 14:01:53 UTC
(In reply to Lars Wendler (Polynomial-C) from comment #7)
> Seems like this patch has never been tested with the ebuild.
> 
> It's caused by the DOS line endings some of the source files the patch
> touches have.

Hi Lars, apologies for this. I can promise you that I did test this -- to the extent of playing a few rounds of a game I wasn't familiar with to ensure everything was working okay with some new dependencies.

What happened was that git converted *at the point of commit* the line-endings. I tested fully pre-commit (which is my normal workflow, to prevent accidentally pushing something not ready), and did not test post-commit, hence the error.

Anyway, this is a bit embarrassing, but I've adjusted my git settings from the default now (autocrlf) to avoid this happening in future. Thanks to you and toralf.