A new version is out. Reproducible: Always
Unfortunately this version of viking fails to compile (in various ways depending on USE flags) and I'm afraid I don't have time to track down these issues and look for fixes.
I can successfully compile with USE="exif gps magic nls sqlite". On the other hand, 1.7 doesn't compile for me. Can you point out which USE flag combinations are not working? I might be able to help.
1.7 fails to compile for me with gpsd-3.20 due to a libgps API change (gps_fix_t.time is now timespec_t). 1.8 compiles fine using the existing ebuild from 1.7-r1 with no changes. USE="exif gps magic nls sqlite"
(In reply to Alessandro Di Federico from comment #2) > I can successfully compile with USE="exif gps magic nls sqlite". > > On the other hand, 1.7 doesn't compile for me. > > Can you point out which USE flag combinations are not working? > I might be able to help. FEATURES=test fails (on the documentation step). The documentation seems to be broken in some way. xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' viking-C.omf warning: failed to load external entity "C/geoclue_layer.xml" ./C/viking.xml:2266: element include: XInclude error : could not load C/geoclue_layer.xml, and no fallback was found ./C/viking.xml:20: element article: validity error : Element article content does not follow the DTD, expecting ((title , subtitle? , titleabbrev?)? , articleinfo? , tocchap? , lot* , (((calloutlist | glosslist | bibliolist | itemizedlist | orderedlist | segmentedlist | simplelist | variablelist | caution | important | note | tip | warning | literallayout | programlisting | programlistingco | screen | screenco | screenshot | synopsis | cmdsynopsis | funcsynopsis | classsynopsis | fieldsynopsis | constructorsynopsis | destructorsynopsis | methodsynopsis | formalpara | para | simpara | address | blockquote | graphic | graphicco | mediaobject | mediaobjectco | informalequation | informalexample | informalfigure | informaltable | equation | example | figure | table | msgset | procedure | sidebar | qandaset | task | anchor | bridgehead | remark | highlights | abstract | authorblurb | epigraph | indexterm | beginpage)+ , (sect1* | refentry* | simplesect* | section*)) | sect1+ | refentry+ | simplesect+ | section+) , (toc | lot | index | glossary | bibliography | appendix | colophon | ackno)*), got (articleinfo indexterm section section section section section section section section section section xi:include section section section section section section section section section ) ./C/viking.xml:2266: element include: validity error : No declaration for element include ./C/viking.xml:2266: element include: validity error : No declaration for attribute href of element include ./C/viking.xml:2266: element include: validity error : No declaration for attribute xmlns:xi of element include ./C/viking.xml:826: element xref: validity error : IDREF attribute linkend references an unknown ID "GeoClue" Document ./C/viking.xml does not validate
Tests apart, I think we should bump. 1.8 compiles (at least under some conditions), 1.7 doesn't.
It's seems the download source on Sourceforge is broken. When using the download source from https://github.com/viking-gps/viking/ at least the error in comment #4 is gone. You will find a working ebuild in the attachment. Is it sufficient to post that ebuild here or do I have to file a pull request?
Created attachment 662548 [details] viking-1.8.ebuild ebuild for version 1.8
Created attachment 662551 [details, diff] files/viking-1.8-no-common.patch patch for files directory
Thanks for the ebuilds, they are working perfectly fine on my machine with USE="doc exif gps magic nls sqlite" (including all tests PASSed). viking-1.7 fails to compile for me due to API changes in gosd. I'd also vote to bump. @graaff@gentoo.org: Are you still experiencing the docs and test failures with the ebuilds attached here? Would it speed up the process if someone (I could do it) submits those ebuilds as PR? Maybe the mapnik USE flag and DEPS should be dropped since mapnik is no longer in the reop.
(In reply to mario.haustein from comment #7) > Created attachment 662548 [details] > viking-1.8.ebuild > > ebuild for version 1.8 Thanks. I've incorporated most of your changes, and this also exposed my problem with tests. I was missing gtk-doc as a dependency but the errors masked this issue. With eautoreconf this was exposed in the prepare phase. Instead of the unpack phase I've redefined S which is more common practice.
(In reply to jannis from comment #9) > Maybe the mapnik USE flag and DEPS should be dropped since mapnik is no > longer in the reop. Yes, done.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b6c6f512f863b165edda86f7157db15785f70fb4 commit b6c6f512f863b165edda86f7157db15785f70fb4 Author: Hans de Graaff <graaff@gentoo.org> AuthorDate: 2021-03-12 08:24:04 +0000 Commit: Hans de Graaff <graaff@gentoo.org> CommitDate: 2021-03-12 08:24:11 +0000 sci-geosciences/viking: add 1.8 Closes: https://bugs.gentoo.org/727370 Package-Manager: Portage-3.0.13, Repoman-3.0.2 Signed-off-by: Hans de Graaff <graaff@gentoo.org> sci-geosciences/viking/Manifest | 1 + sci-geosciences/viking/viking-1.8.ebuild | 100 +++++++++++++++++++++++++++++++ 2 files changed, 101 insertions(+)
