Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 722288 - sci-electronics/kicad-5.1.5-r1 lib_tree_model.cpp:78:14: error: ‘sort’ is not a member of ‘std’
Summary: sci-electronics/kicad-5.1.5-r1 lib_tree_model.cpp:78:14: error: ‘sort’ is not...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Zoltan Puskas
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks: boost-1.74
  Show dependency tree
 
Reported: 2020-05-10 23:14 UTC by Thomas Posch
Modified: 2020-05-15 13:21 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (kicad-5.1.5-r1:20200510-222855.log,926.40 KB, text/x-log)
2020-05-10 23:14 UTC, Thomas Posch
Details
emerge --info '=sci-electronics/kicad-5.1.5-r1::gentoo' (after the fix) (kicad-5.1.5-r1.info_POST_FIX,23.05 KB, text/plain)
2020-05-10 23:15 UTC, Thomas Posch
Details
kicad-5.1.5-sort.patch (kicad-5.1.5-sort.patch,412 bytes, patch)
2020-05-10 23:16 UTC, Thomas Posch
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Posch 2020-05-10 23:14:26 UTC
Created attachment 637808 [details]
build.log

Compilation fails with:
kicad-5.1.5/common/lib_tree_model.cpp:78:14: error: ‘sort’ is not a member of ‘std’; did you mean ‘sqrt’?
kicad-5.1.5/common/lib_tree_model.cpp:90:10: error: ‘sort’ is not a member of ‘std’; did you mean ‘sqrt’?

The attached patch #includes <algorithm> in the offending file.

I successfully compiled kicad-5.1.5-r1 on 2020-02-12. Maybe some shuffling in the headers of boost-1.73 is at fault or i switched to a newer gcc since then...
Including <algorithm> when using an algorithm is right in any case.
I will check the upstream project in the coming days to get this fixed.
Comment 1 Thomas Posch 2020-05-10 23:15:55 UTC
Created attachment 637810 [details]
emerge --info '=sci-electronics/kicad-5.1.5-r1::gentoo' (after the fix)
Comment 2 Thomas Posch 2020-05-10 23:16:40 UTC
Created attachment 637812 [details, diff]
kicad-5.1.5-sort.patch
Comment 3 William T Wilson 2020-05-11 03:35:42 UTC
You beat me to it by a nose.  I was busy making a boost patch for openscad first ;)

Anyway, can confirm this is the correct fix.
Comment 4 Thomas Posch 2020-05-11 17:23:54 UTC
Upstream merge request:
https://gitlab.com/kicad/code/kicad/-/merge_requests/207
Comment 5 Zoltan Puskas 2020-05-12 04:26:06 UTC
Ran into this today myself. Thanks for the patch, working on new revision of the ebuild.
Comment 6 Larry the Git Cow gentoo-dev 2020-05-14 10:35:58 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0eea69141f8a758b5205b69a1495332aff9e78e9

commit 0eea69141f8a758b5205b69a1495332aff9e78e9
Author:     Zoltan Puskas <zoltan@sinustrom.info>
AuthorDate: 2019-12-19 10:26:24 +0000
Commit:     Alexey Shvetsov <alexxy@gentoo.org>
CommitDate: 2020-05-14 10:34:07 +0000

    sci-electronics/kicad: Fix build failure and QA
    
    Fix recent build failure in KiCAD. Also apply backported
    patches from upstream to address QA issues that remained
    since introducing this version of the ebuild.
    
    Package-Manager: Portage-2.3.80, Repoman-2.3.19
    Signed-off-by: Zoltan Puskas <zoltan@sinustrom.info>
    Closes: https://bugs.gentoo.org/682480
    Closes: https://bugs.gentoo.org/722288
    Signed-off-by: Alexey Shvetsov <alexxy@gentoo.org>

 .../kicad/files/kicad-5.1.5-ninja-build.patch      |  6 +++---
 .../kicad/files/kicad-5.1.5-strict-aliasing.patch  | 25 ++++++++++++++++++++++
 .../kicad/files/kicad-algorithm-header.patch       | 11 ++++++++++
 sci-electronics/kicad/files/kicad-metainfo.patch   | 12 +++++++++++
 ...kicad-5.1.5-r1.ebuild => kicad-5.1.5-r2.ebuild} | 17 ++++++++++++++-
 5 files changed, 67 insertions(+), 4 deletions(-)
Comment 7 Thomas Posch 2020-05-15 13:21:36 UTC
My request has been merged. Will appear in 5.1.7.