Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 721316 - app-office/libreoffice-6.4.3.2 installs hundreds of duplicate icons
Summary: app-office/libreoffice-6.4.3.2 installs hundreds of duplicate icons
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Office Team
URL:
Whiteboard: fixed in 7.1
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2020-05-06 18:49 UTC by Chris Mayo
Modified: 2021-04-03 18:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
hicolor icon theme installed in /usr/share/icons/hicolor/ is unnecessarily duplicated in /usr/share/icons/gnome/ (gnomeicons.patch,795 bytes, patch)
2020-05-06 18:49 UTC, Chris Mayo
Details | Diff
Patch to not install unusable SVGs and locolor theme (scalable.patch,662 bytes, patch)
2020-08-05 19:32 UTC, Chris Mayo
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Mayo 2020-05-06 18:49:12 UTC
Created attachment 636552 [details, diff]
hicolor icon theme installed in /usr/share/icons/hicolor/ is unnecessarily duplicated in /usr/share/icons/gnome/

1) SVG icons are installed in fixed size hicolor theme subdirectorie

e.g.:
/usr/share/icons/hicolor/48x48/apps $ ls -w 60 libreoffice-*
libreoffice-base.png     libreoffice-impress.svg
libreoffice-base.svg     libreoffice-main.png
libreoffice-calc.png     libreoffice-main.svg
libreoffice-calc.svg     libreoffice-math.png
libreoffice-chart.png    libreoffice-math.svg
libreoffice-chart.svg    libreoffice-startcenter.png
libreoffice-draw.png     libreoffice-startcenter.svg
libreoffice-draw.svg     libreoffice-writer.png
libreoffice-impress.png  libreoffice-writer.svg


Fixed for me by adding to src_prepare():

find sysui/desktop/icons/hicolor/ -name "*.svg" ! -path "*scalable*" -exec rm {} \;


2) Duplicate gnome icon theme installed

hicolor icon theme installed in /usr/share/icons/hicolor/ is unnecessarily duplicated in /usr/share/icons/gnome/

My attached patch fixes this for me.
Signed-off-by: Chris Mayo <aklhfex@gmail.com>


Upstream bug reports:
1) https://bugs.documentfoundation.org/show_bug.cgi?id=132737
2) https://bugs.documentfoundation.org/show_bug.cgi?id=132787
Comment 1 Chris Mayo 2020-05-08 09:42:47 UTC
60 duplicate SVGs in the locolor theme too.

find sysui/desktop/icons/locolor/ -name "*.svg" ! -path "*scalable*" -exec rm {} \;

Maybe don't even install locolor icons - is there a Gentoo ebuild for it? Useless without an index.theme?
Comment 2 Chris Mayo 2020-05-08 10:28:45 UTC
1) Looks more complicated than this, some of the SVGs are not duplicates, and what is in the scalable directories contain a range of sized images within one.
Comment 3 Chris Mayo 2020-08-05 19:32:33 UTC
Created attachment 653308 [details, diff]
Patch to not install unusable SVGs and locolor theme

This patch skips installing the locolor theme, the mimetypes SVGs (which I think are unusable because they each contain multiple images) and SVGs into fixed size hicolor directories.
Comment 4 Andreas Sturmlechner gentoo-dev 2020-08-06 20:57:24 UTC
Please submit this upstream and put the link in this bug.
Comment 5 Chris Mayo 2020-08-07 08:06:45 UTC
Bugs (linked in opening comment, I'll try adding both to the URL field now), Gerrit (linked in bugs) and a mailing list post with a lurid headline already sent.

The gnomeicons.patch did get some acks, but it broke deb and rpm creation. I can guess how to fix the deb but the rpm spec file has a number of legacy symlinks that might be affected.

I realise it may well not be appropriate to add these to the ebuild - just making them available in case they are useful to anyone (work fine from /etc/portage/patches/app-office/libreoffice/).
Comment 6 Chris Mayo 2021-04-03 18:41:21 UTC
Fixed in app-office/libreoffice-7.1.2.2.