Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 721018 - net-print/hplip: hp-doctor/hp-check runs forever
Summary: net-print/hplip: hp-doctor/hp-check runs forever
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Daniel Pielmeier
URL:
Whiteboard:
Keywords:
: 740688 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-05-05 04:37 UTC by Brian Gloyer
Modified: 2020-10-19 12:09 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix issues related to hp-check and hp-doctor (hplip-3.20.3-check.patch,2.68 KB, patch)
2020-05-10 13:04 UTC, Daniel Pielmeier
Details | Diff
Fix infinite loop when checking dependencies (hplip-3.20.9-utils-symlink.patch,696 bytes, patch)
2020-10-06 12:49 UTC, Daniel Pielmeier
Details | Diff
Fix infinite loop when checking dependencies (hplip-3.20.9-utils-symlink.patch,699 bytes, patch)
2020-10-06 20:34 UTC, Daniel Pielmeier
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Gloyer 2020-05-05 04:37:40 UTC
hp-doctor runs forever.  It worked in a previous version (3.18.6 I think).

>hp-doctor -g
hp-doctor[13883]: debug: ['unknown', 'mepis', 'debian', 'suse', 'mandriva', 'fedora', 'redhat', 'rhel', 'slackware', 'gentoo', 'redflag', 'ubuntu', 'xandros', 'freebsd', 'linspire', 'ark', 'pclinuxos', 'centos', 'igos', 'linuxmint', 'linpus', 'gos', 'boss', 'lfs', 'manjarolinux']
hp-doctor[13883]: debug: HPLIP Description= Public version=3.19.12 Internal version = 3.19.12
hp-doctor[13883]: debug: Determining distro...
hp-doctor[13883]: debug: Able to detect distro
hp-doctor[13883]: debug: Distro name=gentoo
hp-doctor[13883]: debug: Distro version=2.6
hp-doctor[13883]: debug: distro=9, distro_version=2.6
hp-doctor[13883]: debug: Enable PPD install: True (False=drv)
hp-doctor[13883]: debug: Default UI toolkit: Qt4
hp-doctor[13883]: debug: Checking for dependency 'epm'...

hp-doctor[13883]: debug: Checking: epm --version (min ver=0.000000)
hp-doctor[13883]: debug: Not found!
hp-doctor[13883]: debug: have epm = False
hp-doctor[13883]: debug: Checking for dependency 'automake'...

hp-doctor[13883]: debug: Checking: automake --version (min ver=0.000000)
hp-doctor[13883]: debug: automake (GNU automake) 1.16.1
Copyright (C) 2018 Free Software Foundation, Inc.
License GPLv2+: GNU GPL version 2 or later <https://gnu.org/licenses/gpl-2.0.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Tom Tromey <tromey@redhat.com>
       and Alexandre Duret-Lutz <adl@gnu.org>.

hp-doctor[13883]: debug: Found.
hp-doctor[13883]: debug: have automake = True
hp-doctor[13883]: debug: Checking for dependency 'libjpeg'...

hp-doctor[13883]: debug: Checking for library 'libjpeg'...
hp-doctor[13883]: debug: Found.
hp-doctor[13883]: debug: Searching for file 'jpeglib.h' in '/usr/include'...
[[at this point it pegs a cpu and runs forever]]



>emerge --info hplip
Portage 2.3.89 (python 3.6.10-final-0, default/linux/amd64/17.1/desktop/plasma, gcc-9.2.0, glibc-2.30-r8, 5.2.11-gentoo x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-5.2.11-gentoo-x86_64-Intel-R-_Core-TM-_i7-8700_CPU_@_3.20GHz-with-gentoo-2.6
KiB Mem:    16287688 total,   7814812 free
KiB Swap:  125975548 total, 125975548 free
Timestamp of repository gentoo: Sun, 26 Apr 2020 17:30:01 +0000
Head commit of repository gentoo: 00bf0487dbb811dda18eaa7626e6c9e38b15bf6f
Timestamp of repository guru: Fri, 24 Apr 2020 15:39:39 +0000
Head commit of repository guru: 2abf7f72c6f0d8b6549228b00389e187a4a540de

Timestamp of repository jm-overlay: Sun, 19 Apr 2020 17:13:02 +0000
Head commit of repository jm-overlay: e6776212108b6007436cb83f2671c3aa0ed83da7

sh bash 4.4_p23-r1
ld GNU ld (Gentoo 2.33.1 p2) 2.33.1
app-shells/bash:          4.4_p23-r1::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.30.1::gentoo
dev-lang/python:          2.7.18::gentoo, 3.6.10-r2::gentoo, 3.7.7-r2::gentoo, 3.8.2-r2::gentoo
dev-util/cmake:           3.16.5::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.6-r1::gentoo
sys-apps/openrc:          0.42.1::gentoo
sys-apps/sandbox:         2.13::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.13.4-r2::gentoo, 1.16.1-r1::gentoo
sys-devel/binutils:       2.33.1-r1::gentoo
sys-devel/gcc:            9.2.0-r3::gentoo, 10.0.1_pre9999::gentoo
sys-devel/gcc-config:     2.2.1::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 5.4::gentoo (virtual/os-headers)
sys-libs/glibc:           2.30-r8::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-extra-opts: 
    sync-rsync-verify-metamanifest: yes
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-jobs: 1

guru
    location: /var/db/repos/guru
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/guru.git
    masters: gentoo

jm-overlay
    location: /var/db/repos/jm-overlay
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/jm-overlay.git
    masters: gentoo

localrepo
    location: /usr/local/portage
    masters: gentoo

Installed sets: @larry, @printer, @weekly
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=native -O2 -pipe"
DISTDIR="/home/hddroot/portage/distfiles"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms sign strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="ftp://ftp.gtlib.gatech.edu/pub/gentoo rsync://rsync.gtlib.gatech.edu/gentoo http://www.gtlib.gatech.edu/pub/gentoo http://gentoo.osuosl.org/ http://mirror.lug.udel.edu/pub/gentoo/ rsync://gentoo.cs.uni.edu/gentoo-distfiles http://gentoo.cs.uni.edu/ http://gentoo.cs.utah.edu/"
LANG="C"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j12"
PKGDIR="/home/hddroot/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi activities alsa amd64 berkdb bluetooth branding bzip2 cairo cdda cdr cli crypt cups dbus declarative dri dts dvd dvdr elogind emboss encode exif flac fortran gdbm gif gpm gtk iconv icu ipv6 jpeg kde kipi kwallet lcms ldap libnotify libtirpc mad mng mp3 mp4 mpeg multilib ncurses nls nptl ogg opengl openmp pam pango pcre pdf phonon plasma png policykit ppds qml qt5 readline sdl seccomp semantic-desktop spell split-usr ssl startup-notification svg tcpd tiff truetype udev udisks unicode upower usb vorbis widgets wxwidgets x264 xattr xcb xcomposite xml xv xvid zlib" ABI_X86="64" ADA_TARGET="gnat_2018" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6" RUBY_TARGETS="ruby24 ruby25" SANE_BACKENDS="hp" USERLAND="GNU" VIDEO_CARDS="intel i965" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

=================================================================
                        Package Settings
=================================================================

net-print/hplip-3.19.12-r1::gentoo was built with the following:
USE="X hpcups kde libnotify (policykit) qt5 scanner snmp -doc -fax -hpijs -libressl -libusb0 -minimal -parport -static-ppds" ABI_X86="(64)" PYTHON_SINGLE_TARGET="python3_6 -python3_7"
Comment 1 Francesco Turco 2020-05-05 08:06:05 UTC
Do you have a /usr/include/jpeglib.h file?
It should belong to media-libs/libjpeg-turbo.

See also: https://forums.gentoo.org/viewtopic-p-8306276.html#8306276
Comment 2 Brian Gloyer 2020-05-06 00:43:40 UTC
I do have /usr/include/jpeglib.h from media-libs/libjpeg-turbo.

I think I'm seeing the same hp-doctor problem mentioned in that forum post (that was on hplip 3.18.12).  My printer is working fine so it is a problem with hp-doctor.

There are a few more posts out there with the same problem, these are from 2017:
https://forums.gentoo.org/viewtopic-t-1065638-highlight-hpdoctor.html
https://forums.gentoo.org/viewtopic-t-1071492-highlight-hpdoctor.html

this one from 2014 shows it working:
https://forums.gentoo.org/viewtopic-t-952040-highlight-hpdoctor.html

It worked for me in Feb 2019 so it doesn't seem to be tied to a particular version.

hp-check also has the same problem.
Comment 3 Brian Gloyer 2020-05-06 03:28:40 UTC
I think I found the cause.  There is a symbolic link that points to its parent and hp-doctor goes into a loop expanding the tree.

$ ls -l /usr/include/node/src
lrwxrwxrwx 1 root root 1 Mar 27 00:06 /usr/include/node/src -> .

$ qfile /usr/include/node/src
net-libs/nodejs: /usr/include/node/src
Comment 4 Daniel Pielmeier gentoo-dev 2020-05-10 10:49:16 UTC
Pretty sure this problem existed before 3.18.6 as this has been reported upstream already for 3.11.3.

I think it now pops up again because net-libs/nodejs introduced this symlink in a recent version.
Comment 5 Daniel Pielmeier gentoo-dev 2020-05-10 13:04:55 UTC
Created attachment 637524 [details, diff]
Fix issues related to hp-check and hp-doctor

I uncommented the symlink check as recommended in the upstream bug. Afterwards hp-check and hp-doctor rune although slower as I remember.

There were also problems detecting pillow versions > 7.0.0 as well as PyQT5.

This patch tries to fix all this issues although I am not sure about the PyQt5 fix.
Comment 6 Daniel Pielmeier gentoo-dev 2020-05-29 17:53:59 UTC
Should be fixed in Git with hplip-3.20.5.
Comment 7 tt_1 2020-09-06 14:37:08 UTC
I'm sorry, but this came back with net-print/hplip-3.20.6-r1, where hp-check keeps hanging in a deadlock. Problem can be solved by removing net-libs/nodejs, where it seems to have found a symlink it happily follows until eternity. 

Shall we reopen here and close my bug as duplicate?
Comment 8 Daniel Pielmeier gentoo-dev 2020-10-06 10:44:15 UTC
Apparently the fix does not work for everyone.
Comment 9 Daniel Pielmeier gentoo-dev 2020-10-06 10:44:44 UTC
*** Bug 740688 has been marked as a duplicate of this bug. ***
Comment 10 Daniel Pielmeier gentoo-dev 2020-10-06 12:49:36 UTC
Created attachment 664066 [details, diff]
Fix infinite loop when checking dependencies

(In reply to tt_1 from comment #7)
> I'm sorry, but this came back with net-print/hplip-3.20.6-r1, where hp-check
> keeps hanging in a deadlock. Problem can be solved by removing
> net-libs/nodejs, where it seems to have found a symlink it happily follows
> until eternity. 
> 
> Shall we reopen here and close my bug as duplicate?

I took the time and tried to analyse the problem. To break the infinite loop it should stop if the object to check is a link and if this link points to a directory as the directories will be checked anyway.

Can you please verify if the attached patch fixes the issue?
Comment 11 tt_1 2020-10-06 19:20:29 UTC
yay, success! :) 

I need to use the reverted patch from https://bugs.gentoo.org/740688#c8 first, and add your new patch on top of it

tested with hplip-3.20.6-r1 and python:3.7 as systems python
Comment 12 Daniel Pielmeier gentoo-dev 2020-10-06 20:13:48 UTC
(In reply to tt_1 from comment #11)
> yay, success! :) 

Thanks for confirming. This time I took a look at it myself instead of blindly copying the code from others. My python skills are limited but I think the solution is somewhat same.

> I need to use the reverted patch from https://bugs.gentoo.org/740688#c8
> first, and add your new patch on top of it

Of course the patch is based on the original upstream release.

> tested with hplip-3.20.6-r1 and python:3.7 as systems python

This will go in hplip 3.20.9 however. It might take some time as other requirements have to be fulfilled before I can add the new version.
Comment 13 Daniel Pielmeier gentoo-dev 2020-10-06 20:34:20 UTC
Created attachment 664138 [details, diff]
Fix infinite loop when checking dependencies

Use continue instead of break. Only the link pointing to the directory should be omitted and not also everything else which follows.

Can you please check again if it also works for you this way?
Comment 14 Daniel Pielmeier gentoo-dev 2020-10-18 16:02:10 UTC
Just added hplip-3.20.9. Please test if the new version fixes the issue.
Comment 15 Brian Gloyer 2020-10-19 04:31:38 UTC
Yes, 3.20.9 works for me
Comment 16 Daniel Pielmeier gentoo-dev 2020-10-19 06:29:29 UTC
(In reply to Brian Gloyer from comment #15)
> Yes, 3.20.9 works for me

Thanks for confirming!
Comment 17 tt_1 2020-10-19 12:09:12 UTC
I checked with python3.8, bug is solved indeed. And also it seems you have upstreamed it already in #755441?