Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 718762 - dev-python/dnslib: removal (was: need py3.7, 3.8 port, also bump, also tests)
Summary: dev-python/dnslib: removal (was: need py3.7, 3.8 port, also bump, also tests)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Deadline: 2020-07-03
Assignee: Tobias Klausmann (RETIRED)
URL:
Whiteboard:
Keywords: PMASKED
Depends on:
Blocks: python3.7-compat
  Show dependency tree
 
Reported: 2020-04-21 16:37 UTC by Michał Górny
Modified: 2020-07-13 04:52 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-04-21 16:37:14 UTC
The packages are stuck on py3.6 which means they will be pain once we switch to 3.7.  Please test them on 3.7 *and* 3.8 (so we don't to revisit this in a few months), and update PYTHON_COMPAT appropriately.  If it doesn't work, please either fix it, remove Python or issue last rites.  Please consider this urgent.

Also, it's 6 versions behind upstream.

Also, it's missing tests.  Please note that upstream test running script doesn't return errors properly, so it's useless.

Overall, this package looks horribly bad quality and has no revdeps.  I'd suggest treecleaning it.
Comment 1 Tobias Klausmann (RETIRED) gentoo-dev 2020-04-22 08:22:39 UTC
Yeah, this package should be lastrite'd. My use for it has gone away over a year ago (hence my neglet).

@treecleaners, we can lastrite this sooner rather than later.
Comment 2 Larry the Git Cow gentoo-dev 2020-06-03 06:41:44 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e5cc2b38872b9521d4313db50ee320901d18a4ec

commit e5cc2b38872b9521d4313db50ee320901d18a4ec
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2020-06-03 06:19:44 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2020-06-03 06:41:34 +0000

    package.mask: Last rite dev-python/dnslib
    
    Bug: https://bugs.gentoo.org/718762
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 profiles/package.mask | 5 +++++
 1 file changed, 5 insertions(+)
Comment 3 Nico Baggus 2020-06-15 11:10:36 UTC
Well then there is dnslib 0.9.14 on github.   https://github.com/paulc/dnslib
the pypy site refers to that one as well.
That version has in it's release notes fixes for Python v3.9 

wrt. revdep: certbot-dns-standalone is built on this library.
although that proposed ebuild is largly ignored.
See: #702740
Comment 4 Nico Baggus 2020-06-15 11:13:01 UTC
rename the ebuild to 0.9.14 and adding python3_7 builds fine, i also added python3_8 but didn't build that one yet.

[ebuild   R   ] dev-python/dnslib-0.9.14  PYTHON_TARGETS="python3_6 python3_7 -pypy3 -python3_8"
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-06-15 11:13:54 UTC
The primary problem with dnslib is that the tests aren't written to be run in automated environment but rather by human who reads whether they fails.  Also, the code looks just horrible but I guess it's a matter of personal taste.
Comment 6 Nico Baggus 2020-06-15 11:31:48 UTC
Ok i opened a case on github:  https://github.com/paulc/dnslib/issues/12
Comment 7 Nico Baggus 2020-07-01 21:00:27 UTC
According to the dev there is automated testing,
From github issue:

There is already an automated testing script which tests against multiple versions of python (see run_tests.sh)

Also if you look in .github/workflows/test.yml there is a set of automated CI tests which run on each commit (essentially the same as run_tests.sh)
Comment 8 Larry the Git Cow gentoo-dev 2020-07-13 04:52:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9b529964fb17b32999ba976a7115eed6df9bb32c

commit 9b529964fb17b32999ba976a7115eed6df9bb32c
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2020-07-13 04:49:03 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2020-07-13 04:49:21 +0000

    dev-python/dnslib: Remove last-rited pkg
    
    Closes: https://bugs.gentoo.org/718762
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-python/dnslib/Manifest            |  1 -
 dev-python/dnslib/dnslib-0.9.6.ebuild | 18 ------------------
 dev-python/dnslib/metadata.xml        | 11 -----------
 profiles/package.mask                 |  5 -----
 4 files changed, 35 deletions(-)